Restore i18n fallback for on-demand pages reached through a fallback route by miottid · Pull Request #18474 · withastro/astro · GitHub
Skip to content

Restore i18n fallback for on-demand pages reached through a fallback route - #18474

Open
miottid wants to merge 1 commit into
withastro:mainfrom
miottid:fix/i18n-fallback-on-demand-status
Open

miottid wants to merge 1 commit into
withastro:mainfrom
miottid:fix/i18n-fallback-on-demand-status

Conversation

@miottid

@miottid miottid commented Oct 21, 2026

Copy link
Copy Markdown

Changes

Fixes #18473

Testing

  • test/units/i18n/i18n-app.test.ts: on-demand route reached through a fallback route with rewrite (200, body) and redirect (302 + Location); a redirect or status set by the page is preserved.
  • test/units/routing/routing-helpers.test.ts: the extracted isFallbackRouteMatch helper.
  • test/i18n-fallback-on-demand.test.ts with the i18n-fallback-on-demand fixture: full build with the test adapter for both fallback types; the prerendered fallback page assertions document the build path, which was not affected.

Docs

No docs update needed: this restores the documented fallbackType behavior for on-demand pages.

@changeset-bot

changeset-bot Bot commented Oct 21, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Oct 21, 2026
@codspeed

codspeed Bot commented Oct 21, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n fallback: on-demand pages answer 302 with the page body and no Location (regression since 6.0)

1 participant