{{ message }}
Repository navigation
Conversation
Refactor file system operations to preserve accessed and modified timestamps during file copy mimicking normal file system copy actions.
github-actions
Bot
added
the
pkg: astro
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor file system operations on cached build files to preserve accessed and modified timestamps during file copy on all systems. Previously, these timestamps would only be preserved on static builds on MacOS.
This allows for faster and leaner synchronization of cached assets (fonts, images, etc.), and is especially useful when propagating incremental builds with many cached files.
Changes
fs.promises.copyFileis calledTesting
All current tests pass.
Built
astropackage linked to local repository and used for build; cached assets now maintain their modified date.Unsure how to build a new test for this case specifically.Edit: test has been added confirming that built assets maintain their cached version's modified date
Docs
No changes to docs as this is purely a file system optimization