{{ message }}
Wrap responsive image styles in @layer astro.images to respect CSS cascade layers#17141
Merged
Conversation
…user layer styles
1 task
|
I tried this and can confirm it works as expected. |
matthewp
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #17139
Changes
generateImageStylesCSS()in@layer astro.images { … }. Per the CSS cascade spec, unlayered styles always beat layered styles regardless of specificity — so the previous unlayered:where([data-astro-image=constrained]){max-width:100%}was silently overriding any usermax-widthdefined inside a@layer, even though:where()has zero specificity. Putting these defaults into a named layer restores the original intent of:where(): Astro's image styles should always be easy for users to override.astro.imagesuses a dotted namespace to avoid collisions with user-defined layer names while remaining valid for CSS processors (e.g. lightningcss).astro.imagessits below your own layers, declare the order explicitly:@layer astro.images, layout, page, components;. Without an explicit order declaration, the first-seen layer wins — which may or may not beastro.imagesdepending on stylesheet load order.Testing
packages/astro/test/units/assets/utils.test.tsto expect the@layer astro.images { … }wrapper around the generated CSS output.Docs
image.responsiveStylesis already documented as producing overridable defaults; this fix makes that promise actually true when users write CSS layers.