added 'header with underline' rule and some other minor changes by tbrugz · Pull Request #37 · winterstein/Eclipse-Markdown-Editor-Plugin · GitHub
Skip to content

added 'header with underline' rule and some other minor changes - #37

Merged
paulvi merged 6 commits into
winterstein:masterfrom
tbrugz:master
Feb 21, 2014
Merged

paulvi merged 6 commits into
winterstein:masterfrom
tbrugz:master

Conversation

@tbrugz

@tbrugz tbrugz commented Feb 11, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@paulvi

paulvi commented Feb 12, 2014

Copy link
Copy Markdown
Collaborator

@tbrugz

tbrugz commented Feb 12, 2014

Copy link
Copy Markdown
Contributor Author

@paulvi I personally think that small commits may be easier to revert if things go bad, but that's not a big issue for me

@paulvi

paulvi commented Feb 13, 2014

Copy link
Copy Markdown
Collaborator

easier to revert

Oh, that is interesting.

@tbrugz

tbrugz commented Feb 20, 2014

Copy link
Copy Markdown
Contributor Author

@paulvi @winterstein commit 6ff204f in this PR adds the grey background.

Unfortunately the 'header with underline' rule only seems to work when you open a .md file and not, when editting, you create a new header. If you have any tips for dealing with those IRule's I would appreciate

paulvi pushed a commit that referenced this pull request Feb 21, 2014
added 'header with underline' rule and some other minor changes
@paulvi
paulvi merged commit a0b886f into winterstein:master Feb 21, 2014
@paulvi

paulvi commented Feb 21, 2014

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants