{{ message }}
Repository navigation
fingerprint: hash only git-tracked kit files in a git checkout - #109
Open
henrychao521 wants to merge 1 commit into
Open
henrychao521 wants to merge 1 commit into
henrychao521 wants to merge 1 commit into
Conversation
fingerprintOfSkill walked the kit folder on disk, so git-ignored or untracked files there (kit/audit.txt, kit/shots/, a .orig left by a merge) changed the fingerprint publish.mjs writes to figure.json. The gallery's fingerprintAt hashes only the files git tracks, found no published version of the skill with that kit, and failed the figure. When the skill is a git checkout, hash exactly the files git tracks under kit/ and scripts/inline-kit.mjs, as the gallery does; a folder outside git falls back to the files on disk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
When the skill is a git checkout, hash exactly the files git tracks under kit/ and scripts/inline-kit.mjs, as the gallery does; a folder outside git falls back to the files on disk.
Why
fingerprintOfSkill walked the kit folder on disk, so git-ignored or untracked files there (kit/audit.txt, kit/shots/, a .orig left by a merge) changed the fingerprint publish.mjs writes to figure.json. The gallery's fingerprintAt hashes only the files git tracks, found no published version of the skill with that kit, and failed the figure.
Tests
scripts/fingerprint.test.mjsEach new or changed test fails on main and passes here. On this branch the whole suite that runs without a browser passes (Node 26, the CI's react/typescript/esbuild versions). The browser tests (all
scripts/*.test.mjsthat start Chrome) were run once, one file at a time, with this and the other twelve fix branches I'm sending merged together: all pass.Checks
git status --shortshows only the changes I meant.arcade-cabinetandraptor-enginebuild.mjs --auditendaudit passed.node scripts/lines.mjsprintsline ends: 0on every committed example page in both themes. (turning-stress-light.htmlreports 16 floating ends, identically on main; it is not one of the pages CI checks.)turn-check.mjs --fidelitypasses onturning-dial/build.mjsandstress.mjs, identical to main. I ran the quick turn audit only (--audit --quick): it reports the same four cable-end findings on main and here; I did not do the full run.UnreleasedinCHANGELOG.md.Screenshots
No committed page changes, so there is nothing new to screenshot.
🤖 Generated with Claude Code