Release version 0.61 by cclauss · Pull Request #662 · webpy/webpy · GitHub
Skip to content

Release version 0.61#662

Merged
cclauss merged 7 commits into
masterfrom
setup.py-python_requires
Jul 25, 2020
Merged

Release version 0.61#662
cclauss merged 7 commits into
masterfrom
setup.py-python_requires

Conversation

@cclauss

@cclauss cclauss commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

setup.py: Add python_requires='>=3.5'

This prevents installation on legacy Python and other versions < Python 3.5 as discussed in
https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires

Tasks for making a new release.

  • Reread Packaging Python Projects to make sure you miss no steps...
  • Bump the version in web/__init__.py
  • Update ChangeLog.txt and mark the release date in ChangeLog.txt
  • Check setup.py and update if necessary
  • Check README.md and update if necessary
  • Check MANIFEST.in and update if necessary Added MANIFEST.in to include docs, tests and tools in source package. #628
  • Tag the version and mark it as a release in GitHub
  • python3 -m pip install --upgrade pip setuptools wheel # Important for PyPI page rendering
  • Run python3 setup.py sdist under webpy source code directory to generate package file used to publish to PyPI
  • Run tar tf dist/web.py-<version>.tar.gz to make sure all required files are included.
  • Publish package on PyPI with command python3 setup.py sdist upload
  • Update the documentation on the website (see webpy.github.com repo) Release v0.61 webpy.github.com#137
  • Announce it on the mailing list
  • Update the API docs if required (not required)

This prevents installation on legacy Python and other versions < Python 3.5 as discussed in
https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires
@cclauss cclauss requested review from anandology and iredmail July 23, 2020 20:44

@iredmail iredmail left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please reformat file to satisfy the “black” tool? :)

iredmail
iredmail previously approved these changes Jul 24, 2020
@Nicusor97

Copy link
Copy Markdown

@iredmail

Copy link
Copy Markdown
Contributor

Seems we need a new release immediately for this purpose.

@cclauss you can publish 0.61 if you want.

@Nicusor97

Copy link
Copy Markdown

Will be great if the 0.61 version will be released as soon as possible!

@cclauss

cclauss commented Jul 24, 2020

Copy link
Copy Markdown
Contributor Author

@Nicusor97 Workaround is to pin your dependency for legacy Python:
pip install --upgrade "web.py<0.60;python_version<'3.5'" "web.py;python_version>='3.5'"

@laura-surcel

Copy link
Copy Markdown

@cclauss it's not that easy. I have a package with multiple released versions that are actively used by clients. I cannot pin it in all versions. I can pin it for next releases though but not for the old ones. The python_requires would solve this issue for us.

@cclauss

cclauss commented Jul 24, 2020

Copy link
Copy Markdown
Contributor Author

@anandology Can you please pick up where I left off on the checklist above? I do not have publishing rights on PyPI.

Please ensure to update wheel before creating the dist so that our PyPI page is rendered properly. Thanks.

@Nicusor97 @laura-surcel Please view the Files changed and then click the Review changes green button at the top right of that page and then click Approve.

Positive reviews give project maintainers confidence that these changes are in the best interests of the project.

laura-surcel
laura-surcel previously approved these changes Jul 24, 2020
Nicusor97
Nicusor97 previously approved these changes Jul 24, 2020
@cclauss cclauss changed the title setup.py: Add python_requires='>=3.5' Release version 0.61 Jul 24, 2020
@cclauss cclauss dismissed stale reviews from Nicusor97 and laura-surcel via 2ccd4b0 July 24, 2020 12:02
@cclauss cclauss mentioned this pull request Jul 24, 2020
@cclauss cclauss requested a review from iredmail July 24, 2020 12:03
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files          23       23           
  Lines        4278     4278           
  Branches      627      627           
=======================================
  Hits         2514     2514           
  Misses       1587     1587           
  Partials      177      177           
Flag Coverage Δ
#py35 58.74% <ø> (ø)
#py36 58.78% <ø> (ø)
#py37 58.78% <ø> (ø)
#py38 58.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e58983b...2ccd4b0. Read the comment docs.

@iredmail

iredmail commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

hi @cclauss

Could you also add MANIFEST.in file? see #628

btw, i used pip2 install web.py>=0.51 in my application released weeks ago, and now it failed to install due to missing the python_requires=">=3.5" in 0.60. :)

@cclauss

cclauss commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

btw, i used pip2 install web.py>=0.51

You want python2 -m pip install web.py<0.60 or better yet, just dump legacy Python. ;-)

@iredmail

Copy link
Copy Markdown
Contributor

You want python2 -m pip install web.py<0.60 or better yet, just dump legacy Python. ;-)

Still need to run legacy Python 2 code for few more months while moving to Python 3. No worries about this. :)
Would you like to tag 0.61 now?

@iredmail

Copy link
Copy Markdown
Contributor

Just a remind: once you published to pypi, there's no chance to remove it and re-publish same version.

@cclauss cclauss mentioned this pull request Jul 25, 2020
@iredmail

Copy link
Copy Markdown
Contributor

Should we include README.md in file MANIFEST.in?

@cclauss

cclauss commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

I think we are ready. Is the order of the checklist above incorrect? Do we publish to PyPI first and then tag the release after or vice versa? Only you and @anandology have the rights to publish to PyPI.

@iredmail

Copy link
Copy Markdown
Contributor
  • I suggest tag first, then publish to pypi.
  • Please ask @anandology to grant your account required privileges.

@cclauss

cclauss commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

@iredmail

iredmail commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

Hold on, don't publish to pypi right now. Because you forgot to merge this PR.
Please merge first, remove the github tag, then re-tag. :)

@cclauss cclauss merged commit 5a1a5a4 into master Jul 25, 2020
@iredmail

Copy link
Copy Markdown
Contributor

It's ok to (re-)tag 0.61 in github now, and publish to PYPI. Good job. :)

@cclauss

cclauss commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author
  1. I cannot "re-tag“ on GitHub.
  2. I do not have the permissions required to publish on PyPI.

@cclauss

cclauss commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

My sense is that we need to do a 0.62.

@iredmail

Copy link
Copy Markdown
Contributor

About "re-tag", usually I delete old tag and tag again with same name. I see you already done on GitHub. Well done. :)

btw, I have 3 (bash) shell functions in my ~/.bash_profile (on macOS, Linux can use ~/.bashrc):

gittag() {
    _tag="${1}"

    git tag ${_tag}             # Tag locally
    git push origin ${_tag}     # Tag remotely
}

gitdeletetag() {
    _tag="${1}"

    git tag -d ${_tag}          # Delete tag locally
    git push origin :${_tag}    # Delete tag remotely
}

gitretag() {
    _tag="${1}"

    gitdeletetag ${_tag}
    gittag ${_tag}
}

Then i simply run command like gitretag 0.61 to re-tag. :)

@iredmail

Copy link
Copy Markdown
Contributor

My sense is that we need to do a 0.62.

0.61 is ok IMO. No one use the old 0.61 yet in passed one hour, so quickly fix it and retag is ok for me before publishing on PYPI.

@iredmail

iredmail commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

Please do not publish to PYPI right now, one packaging issue found:

While running python3 setup.py sdist under webpy source code repo, it generates file dist/web.py-0.61.tar.gz, run tar tf dist/web.py-0.61.tar.gz to list all files inside the tar.gz file, you can see some directories defined in file MANIFEST.in are missing: docs, tests, tools.

@iredmail

Copy link
Copy Markdown
Contributor

Fixed incorrect syntax in MANIFEST.in: #663

@iredmail

Copy link
Copy Markdown
Contributor

Re-tagged 0.61. :)
Should be fine to publish to pypi now.

Hi @anandology, please grant @cclauss's pypi account required privileges to publish new release.

@cclauss

cclauss commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

How did you re-tag?!? I could not figure out how to do that.

@iredmail

Copy link
Copy Markdown
Contributor

We don't have privilege to push to github repo directly, and GitHub web UI doesn't support "re-"tag, we have to delete it first, then draft a new release with the latest revision. :(

@cclauss

cclauss commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

@iredmail What is the next step on this release?

@iredmail

iredmail commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

Wait for @anandology to grant you privileges to publish release on pypi.

I can publish too, but we’re not rush and better let you practice and contribute to the project this time. :)

@anandology

Copy link
Copy Markdown
Member

Wait for @anandology to grant you privileges to publish release on pypi.

Done. Added @cclauss as maintainer.

@iredmail FYI, you are already admin in pypi. You can also add other members.

@iredmail

Copy link
Copy Markdown
Contributor

@iredmail FYI, you are already admin in pypi. You can also add other members.

I didn’t notice that :(
Thanks for the remind.

@cclauss go go go, v0.61

@cclauss

cclauss commented Jul 28, 2020

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants