Release version 0.61#662
Conversation
This prevents installation on legacy Python and other versions < Python 3.5 as discussed in https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires
iredmail
left a comment
There was a problem hiding this comment.
Could you please reformat file to satisfy the “black” tool? :)
|
Seems we need a new release immediately for this purpose. @cclauss you can publish 0.61 if you want. |
|
Will be great if the 0.61 version will be released as soon as possible! |
|
@Nicusor97 Workaround is to pin your dependency for legacy Python: |
|
@cclauss it's not that easy. I have a package with multiple released versions that are actively used by clients. I cannot pin it in all versions. I can pin it for next releases though but not for the old ones. The |
|
@anandology Can you please pick up where I left off on the checklist above? I do not have publishing rights on PyPI. Please ensure to update @Nicusor97 @laura-surcel Please view the Files changed and then click the Positive reviews give project maintainers confidence that these changes are in the best interests of the project. |
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 58.76% 58.76%
=======================================
Files 23 23
Lines 4278 4278
Branches 627 627
=======================================
Hits 2514 2514
Misses 1587 1587
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
You want |
Still need to run legacy Python 2 code for few more months while moving to Python 3. No worries about this. :) |
|
Just a remind: once you published to pypi, there's no chance to remove it and re-publish same version. |
|
Should we include |
|
I think we are ready. Is the order of the checklist above incorrect? Do we publish to PyPI first and then tag the release after or vice versa? Only you and @anandology have the rights to publish to PyPI. |
|
|
Hold on, don't publish to pypi right now. Because you forgot to merge this PR. |
|
It's ok to (re-)tag |
|
|
My sense is that we need to do a 0.62. |
|
About "re-tag", usually I delete old tag and tag again with same name. I see you already done on GitHub. Well done. :) btw, I have 3 (bash) shell functions in my Then i simply run command like |
0.61 is ok IMO. No one use the old 0.61 yet in passed one hour, so quickly fix it and retag is ok for me before publishing on PYPI. |
|
Please do not publish to PYPI right now, one packaging issue found: While running |
|
Fixed incorrect syntax in |
|
Re-tagged Hi @anandology, please grant @cclauss's pypi account required privileges to publish new release. |
|
How did you re-tag?!? I could not figure out how to do that. |
|
We don't have privilege to push to github repo directly, and GitHub web UI doesn't support "re-"tag, we have to delete it first, then draft a new release with the latest revision. :( |
|
@iredmail What is the next step on this release? |
|
Wait for @anandology to grant you privileges to publish release on pypi. I can publish too, but we’re not rush and better let you practice and contribute to the project this time. :) |
Done. Added @cclauss as maintainer. @iredmail FYI, you are already admin in pypi. You can also add other members. |

setup.py: Add
python_requires='>=3.5'This prevents installation on legacy Python and other versions < Python 3.5 as discussed in
https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires
Tasks for making a new release.
web/__init__.pyChangeLog.txtand mark the release date in ChangeLog.txtsetup.pyand update if necessaryREADME.mdand update if necessaryMANIFEST.inand update if necessary Added MANIFEST.in to include docs, tests and tools in source package. #628python3 -m pip install --upgrade pip setuptools wheel# Important for PyPI page renderingpython3 setup.py sdistunder webpy source code directory to generate package file used to publish to PyPItar tf dist/web.py-<version>.tar.gzto make sure all required files are included.python3 setup.py sdist upload