{{ message }}
fix(package) Add url for compatibility with webpack@5 (#1598)#1599
Merged
Conversation
glenjamin
requested review from
alexander-akait and
michael-ciniawsky
as code owners
alexander-akait
approved these changes
Dec 13, 2018
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Didn't add tests, as this would require CI to run against webpack v5 to exhibit the problem.
Can reproduce the issue and confirm the fix by installing webpack v5 into this package and running the
preparescript.Motivation / Use-Case
fixes #1598
Breaking Changes
none
Additional Info