{{ message }}
Update samples to work with TypeScript strict mode (part 1)#278
Merged
Conversation
kainino0x
reviewed
Jun 23, 2023
kainino0x
force-pushed
the
chore/strict_true
branch
from
cda5614 to
41b32fe
Compare
Collaborator
Collaborator
|
And do be sure to pull the branch before you continue, because I committed suggestions to it. |
Contributor
Author
|
Thank you for the review! I just did a git pull for your changes. Once I've corrected all the examples, I'll request a re-review from you! |
Collaborator
|
Hi @nash1111, will you still be able to complete this PR? If not, someone else can pick it up (eventually)! |
Contributor
Author
kainino0x
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like this, I want to add types to all samples to enhance safety. If there are no issues, I would like to proceed with adding them to all.