iframe-proxy

ML642 · 2026-10-20T17:06:06Z

Proposed changes

Fix selectByAttribute producing invalid XPath when an option attribute value contains double quotes, such as 12" monitor.

Reuse the existing escapeXPathString helper and add four regression cases covering single, double, mixed, and boundary quotes. Preserve existing whitespace trimming and experimental BiDi behavior.

How you tested

Unit tests for the touched package(s)
Type definition tests (not applicable; public types are unchanged)
Smoke or e2e (real Chrome standalone verification)

node node_modules/vitest/vitest.mjs run packages/webdriverio/tests/commands/element/selectByAttribute.test.ts packages/webdriverio/tests/findStrategy.test.ts

89 tests passed. Three new regression cases failed before the fix.

Local standalone verification script, stored in ignored verification artifacts:

node .agents/verify-artifacts/select-by-attribute-quotes/repro.mjs

64 selection assertions passed in real Chrome: 32 in WebDriver Classic and 32 in BiDi, covering direct options, optgroups, and quoted attribute values.

Oxlint passed for both modified files.

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (not applicable)
I have added proper type definitions for new commands (not applicable)

Backport Request

This change is solely for v10 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Backport applicability to v9 has not been assessed.

Further comments

Pls if you have time , check my other PRs, since i want to continue working on E2E tests (multiremote and so on ) and it is blocked by those two #15980,
#15698

Reviewers: @webdriverio/project-committers

greptile-apps · 2026-10-20T17:08:31Z

pkg-pr-new · 2026-10-20T17:08:36Z

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@16157

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@16157

wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/wdio@16157

@wdio/ai-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/ai-service@16157

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@16157

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@16157

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@16157

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@16157

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@16157

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@16157

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@16157

@wdio/cucumberjs-json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumberjs-json-reporter@16157

@wdio/display-server

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/display-server@16157

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@16157

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@16157

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@16157

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@16157

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@16157

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@16157

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@16157

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@16157

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@16157

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@16157

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@16157

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@16157

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@16157

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@16157

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@16157

@wdio/session

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/session@16157

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@16157

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@16157

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@16157

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@16157

@wdio/snapshot

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/snapshot@16157

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@16157

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@16157

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@16157

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@16157

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@16157

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@16157

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@16157

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@16157

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@16157

commit: c19c163

fix(webdriverio): escape quotes in selectByAttribute values

c19c163

ML642 requested a review from a team as a code owner October 20, 2026 17:06

wdio-bot added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 20, 2026

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

fix(webdriverio): escape quotes in selectByAttribute values - #16157

fix(webdriverio): escape quotes in selectByAttribute values#16157
ML642 wants to merge 1 commit into
webdriverio:mainfrom
ML642:fix/select-by-attribute-quotes

ML642 commented Oct 20, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 20, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

ML642 commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

How you tested

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

greptile-apps Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

pkg-pr-new Bot commented Oct 20, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ML642 commented Oct 20, 2026 •

edited

Loading

greptile-apps Bot commented Oct 20, 2026 •

edited

Loading