{{ message }}
Repository navigation
chore(biome): flag barrel files outside package entry points - #729
Merged
Merged
Conversation
The React Native deviceManager and triggerDeeplink modules, and Tauri's portManager, only re-exported @wdio/native-mobile-core and @wdio/native-core. Their callers now import from those packages. Tauri's portManager spec was a copy of native-core's and goes with it. Electron's mock.ts and Tauri's execute.ts no longer re-export createClassMock and clearPluginAvailabilityCache, which nothing imported through them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Biome's noBarrelFile now runs on packages/*/src, except each package's root index.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Release Preview — no release
Updated automatically by ReleaseKit |
…s it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
11 of 12 tasks
7 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on Biome's
noBarrelFileforpackages/*/src, except each package's rootindex.ts, so "no barrel files" is checked bypnpm lintinstead of written in AGENTS.md. Type-only re-exports stay allowed.Five files already re-exported. None was part of a package's public API, since each package exports only its root:
react-native-service/src/deviceManager.tsDeviceManagerfrom@wdio/native-mobile-corereact-native-service/src/commands/triggerDeeplink.tstriggerDeeplinkfrom@wdio/native-mobile-coreservice.tsand the spec import the packagetauri-service/src/portManager.tsPortManagerfrom@wdio/native-corelauncher.tsimports the package, and the launcher specs mockPortManageron@wdio/native-coreelectron-service/src/mock.tscreateClassMockfrom./classMock.jscommands/mock.tsimportsclassMock.jstauri-service/src/commands/execute.tsclearPluginAvailabilityCachefrom../pluginCache.jsexecute.tstauri-service/test/portManager.spec.tswas byte-for-byte the same asnative-core/test/portManager.spec.ts, so it's deleted with the shim. The React Native specs differ from native-mobile-core's, so they stay and now import from the package.Typecheck, unit and integration tests pass for electron-service, react-native-service, tauri-service and native-core.
Once this and #725 merge, the barrel-file line comes out of AGENTS.md.
🤖 Generated with Claude Code