Only iterate over stores if stores exist by cdjackson · Pull Request #37 · webcss/angular-indexedDB · GitHub
Skip to content

Only iterate over stores if stores exist#37

Open
cdjackson wants to merge 1 commit into
webcss:masterfrom
cdjackson:master
Open

Only iterate over stores if stores exist#37
cdjackson wants to merge 1 commit into
webcss:masterfrom
cdjackson:master

Conversation

@cdjackson

Copy link
Copy Markdown

No description provided.

@bramski

bramski commented Sep 4, 2014

Copy link
Copy Markdown

@cdjackson

Copy link
Copy Markdown
Author

Hi,
I certainly can, but there’s an issue. As your repo is behind the original one that I forked, if I create a PR you’ll get all the updates as well. I don’t see this is a problem - I guess you want to start with the latest, but before I do I wanted to make sure this was ok. Otherwise I’d have to cherry pick or something…

Cheers
Chris

On 4 Sep 2014, at 22:55, Bram Whillock notifications@github.com wrote:

hey @cdjackson this project is moving. https://github.com/bramski/angular-indexedDB

Can you add your PR and issue there? Thanks.


Reply to this email directly or view it on GitHub.

@corburn

corburn commented Sep 5, 2014

Copy link
Copy Markdown

@cdjackson the for loop will never run if storeNames is empty.

@cdjackson

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants