{{ message }}
Conversation
…tead of first model level
StevePny
requested changes
May 12, 2025
StevePny
left a comment
StevePny
left a comment
Collaborator
There was a problem hiding this comment.
I think we're getting rhoa from sfcprop already in the fv3 cap. Does this overwrite the value in that data structure?
IPD_Data(nb)%Sfcprop%rhoa
We'll need to test this for at least one experiment run with the coupled model (e.g. 2/15/24) before merging.
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This moves the computation of the air density from the surface layer parameterization to the sfc_diag routine that handles the diagnostics. There, it is computed for the 2-m level. This will ensure that the density reflects well on the density jump at the water/air interface and ensures that it is independent of the height of the first model level.
Fixes # (issue)
How Has This Been Tested?
Not yet.
Checklist:
Please check all whether they apply or not