Activity

1. frash23 commented on Jul 1, 2015

   

   frash23

   on Jul 1, 2015

   Author

   More actions

   I've learned a lot about the Bukkit API since opening this, and I managed to write my own version of your events.on function which does not have this issue:

   exports.listen = function(eventType, func, priority) {
       var scPlugin = scPlugin || server.getPluginManager().getPlugin('scriptcraft');
       var RegisteredListener = org.bukkit.plugin.RegisteredListener;
       var EventExecutor = org.bukkit.plugin.EventExecutor;
       var EventPriority = org.bukkit.event.EventPriority;
   
       priority = EventPriority[ priority || 'NORMAL' ];
   
       // We have to use this method of getting the .getHandlerList
       // method because nashorn is dumb.
       var eventClass = eventType['class'];
       var handlerList = eventClass.getMethod('getHandlerList').invoke(null);
   
       // This map is used for assigning extra variables to the
       // listener's execute() function's `this` scope.
       var extraBinds = {};
   
       // Construct the lsitener's executor.
       var executor = new EventExecutor({
           execute: function(plugin, e) {
   
               // Let's create a function for safely canceling any
               // cancel-able event
               extraBinds.cancel = function() {
                   if(e instanceof org.bukkit.event.Cancellable) e.setCancelled(true);
               };
   
               // We'll assign this map to `func`'s `this` scope
               var bind = {};
               // Append extra variables from outside this scope
               // (currently just this.unregister & this.cancel)
               for(var key in extraBinds) bind[key] = extraBinds[key];
   
               func.call(bind, e);
           }
       });
   
       var listener = new RegisteredListener(scPlugin, executor, priority, scPlugin, false);
       handlerList.register(listener);
   
       // Pass an unregister event to the listener
       extraBinds.unregister = function() {
           handlerList.unregister(listener);
       };
   
       return extraBinds;
   };
   

   Seems like the trick was your version was passing true as the last argument to the org.bukkit.plugin.RegisteredListener constructor. I'll admit I don't know exactly what this means, so I'm not sure if this should be changed in master as well, I'll let you decide that.
2. walterhiggins

   added 2 commits that reference this issue on Mar 19, 2016

   Fix issue #256 and fix issue #287

   8bc648e

   fix issues #256 and #287

   e5eae21
3. walterhiggins

   closed this as completedon Mar 19, 2016