{{ message }}
Repository navigation
Conversation
adampage
changed the title
Member
Author
mcking65
changed the title
Member
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<howard-e> TOPIC: PR 3291 - Remove role of row from TR elements in treegrid example<howard-e> github: https://github.com//pull/3291 <howard-e> Matt_King: This is ready for review too but I'm a little confused by what's going on with the validator here <howard-e> Matt_King: Adam_Page, do you understand why it's still failing here after updating the vnurc even though it's updated <howard-e> Adam_Page: [describes the failure as "Element “tr” is missing one or more of the following attributes: “role”."] <howard-e> Matt_King: I wonder why the validator thinks it needs to have it <howard-e> Matt_King: I thought the validator was throwing an error if it was present before but we had a line in vnurc that said don't throw this error <howard-e> Adam_Page: is there a verbose option for the log? <howard-e> howard-e: Unsure but I can check <howard-e> Matt_King: It's so ironic, right? <howard-e> Matt_King: at least an older version of the validator said the opposite <howard-e> Matt_King: So which one is needed? <howard-e> Adam_Page: just found a note in the vnurc which describes this exact scenario so this really is some weird paradox <howard-e> Matt_King: Wondering if you took out all the rows in vnurc on row, posinset, tr, how it reacts <howard-e> Matt_King: And also setsize but less sure about that <howard-e> Matt_King: if there's still validator bug fixing needed, we should just make sure the right issues are raised <howard-e> Adam_Page: I will comment out those lines in vnurc for now <howard-e> Matt_King: I'm checking to see if the prior validator bugs we filed are still open <howard-e> Matt_King: Ultimately, we want to figure out that if we remove the row=role, what validator needs from us <howard-e> Adam_Page: Yep. I just pushed a commit so I can check what happens there |
Member
Author
|
Heya @mcking65, it looks like we can remove 4 of our vnurc rule filters, but the “ |
Member
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1049.
Preview revised Treegrid Email Inbox Example
WAI Preview Link (Last built on Tue, 10 Jun 2025 20:02:53 GMT).