iframe-proxy

kwy404 · 2026-09-23T22:46:36Z

Components compiled by Vue 2.7 from <script setup> read their bindings through _vm._self._setupProxy, which the compat build does not provide, so mounting them crashes. This adds _setupProxy to the compat private APIs, pointing at the instance proxy, which already exposes the setup state.

Summary by CodeRabbit

Bug Fixes
- Fixed compatibility-mode rendering so render functions can access values returned from setup() and reflect updates to reactive values. Components using setup-provided content now render and update correctly.

close vuejs#11164

coderabbitai · 2026-09-23T22:46:50Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4f09ed68-3239-4ff7-9aa0-077a3cf3e4ca

📥 Commits

Reviewing files that changed from the base of the PR and between 28ea04f and 3247696.

📒 Files selected for processing (2)

packages/runtime-core/src/compat/instance.ts
packages/vue-compat/__tests__/instance.spec.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The compat instance private API now returns setup state through _setupProxy. The test verifies rendered access to setup values, a ref update through _setupProxy, and a reserved-prefix warning.

Changes

Setup proxy access

Layer / File(s)	Summary
Expose and verify setup proxy `packages/runtime-core/src/compat/instance.ts`, `packages/vue-compat/__tests__/instance.spec.ts`	The private API map now returns `setupState` for `_setupProxy`. The test renders `msg` and `$count`, updates the ref through `_setupProxy`, and checks for a reserved-prefix warning.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: edison1105

Merge Risk: ⚪ Minimal · up to 32476

Compat components can access setup bindings through _setupProxy, including ref-backed bindings; the change adds focused coverage, and no merge-blocking risk was identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the compat fix, the exposed `_setupProxy`, the affected Vue 2.7 compiled `<script setup>` components, and the linked issue. It accurately summarizes the main change.
Linked Issues check	✅ Passed	Issue [`#11164`] requires Vue 2.7-compiled `<script setup>` render code to read setup bindings in Vue 3 compat. `installCompatInstanceProperties` exposes `_setupProxy` as `i.setupState`. The regression …
Out of Scope Changes check	✅ Passed	The production change exposes the private API required by [`#11164`]. The test changes add regression coverage for setup binding access, ref unwrapping, reactivity, and the expected deprecation warning.…

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

kwy404 · 2026-09-26T00:15:45Z

@edison1105 I switched to i.setupState in 3247696 as you suggested and added a $count case to the test. Could you take another look when you have time? Thanks!

pkg-pr-new · 2026-09-26T00:28:47Z

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@15618

npm i https://pkg.pr.new/@vue/compiler-core@15618

yarn add https://pkg.pr.new/@vue/compiler-core@15618.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@15618

npm i https://pkg.pr.new/@vue/compiler-dom@15618

yarn add https://pkg.pr.new/@vue/compiler-dom@15618.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@15618

npm i https://pkg.pr.new/@vue/compiler-sfc@15618

yarn add https://pkg.pr.new/@vue/compiler-sfc@15618.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@15618

npm i https://pkg.pr.new/@vue/compiler-ssr@15618

yarn add https://pkg.pr.new/@vue/compiler-ssr@15618.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@15618

npm i https://pkg.pr.new/@vue/reactivity@15618

yarn add https://pkg.pr.new/@vue/reactivity@15618.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@15618

npm i https://pkg.pr.new/@vue/runtime-core@15618

yarn add https://pkg.pr.new/@vue/runtime-core@15618.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@15618

npm i https://pkg.pr.new/@vue/runtime-dom@15618

yarn add https://pkg.pr.new/@vue/runtime-dom@15618.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@15618

npm i https://pkg.pr.new/@vue/server-renderer@15618

yarn add https://pkg.pr.new/@vue/server-renderer@15618.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@15618

npm i https://pkg.pr.new/@vue/shared@15618

yarn add https://pkg.pr.new/@vue/shared@15618.tgz

vue

pnpm add https://pkg.pr.new/vue@15618

npm i https://pkg.pr.new/vue@15618

yarn add https://pkg.pr.new/vue@15618.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@15618

npm i https://pkg.pr.new/@vue/compat@15618

yarn add https://pkg.pr.new/@vue/compat@15618.tgz

commit: 3247696

github-actions · 2026-09-26T00:29:14Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	109 kB	41.3 kB	37 kB
vue.global.prod.js	168 kB	61.5 kB	54.6 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	50.8 kB	19.6 kB	18 kB
createApp	58.9 kB	22.7 kB	20.8 kB
createSSRApp	63.7 kB	24.7 kB	22.5 kB
defineCustomElement	65.2 kB	24.6 kB	22.5 kB
overall	73.5 kB	28 kB	25.5 kB

kwy404 · 2026-09-26T00:33:54Z

fix(compat): expose _setupProxy for Vue 2.7 compiled script setup

28ea04f

close vuejs#11164

edison1105 reviewed Sep 24, 2026

View reviewed changes

Comment thread packages/runtime-core/src/compat/instance.ts Outdated

edison1105 requested changes Sep 24, 2026

View reviewed changes

edison1105 added the scope: v2 compat label Sep 24, 2026

fix(compat): expose setupState as _setupProxy

3247696

kwy404 requested a review from edison1105 September 24, 2026 06:14

edison1105 approved these changes Sep 26, 2026

View reviewed changes

edison1105 added the ready to merge The PR is ready to be merged. label Sep 26, 2026

edison1105 merged commit f08059d into vuejs:main Oct 12, 2026
13 of 14 checks passed

kwy404 added a commit to kwy404/kwy404 that referenced this pull request Oct 12, 2026

README: add vuejs/core#15618

5f5385c

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

fix(compat): expose _setupProxy for Vue 2.7 compiled script setup (fix #11164) - #15618

fix(compat): expose _setupProxy for Vue 2.7 compiled script setup (fix #11164)#15618
edison1105 merged 2 commits into
vuejs:mainfrom
kwy404:fix/compat-setup-proxy

kwy404 commented Sep 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

kwy404 commented Sep 26, 2026

Uh oh!

pkg-pr-new Bot commented Sep 26, 2026

Uh oh!

github-actions Bot commented Sep 26, 2026

Uh oh!

kwy404 commented Sep 26, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

kwy404 commented Sep 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

kwy404 commented Sep 26, 2026

Uh oh!

pkg-pr-new Bot commented Sep 26, 2026

Uh oh!

github-actions Bot commented Sep 26, 2026

Size Report

Bundles

Usages

Uh oh!

kwy404 commented Sep 26, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kwy404 commented Sep 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading