{{ message }}
Repository navigation
cli-sdk: vlt build sets, saves and prompts for allow-scripts - #2034
Open
ruy-bot[bot] wants to merge 3 commits into
Open
ruy-bot[bot] wants to merge 3 commits into
ruy-bot[bot] wants to merge 3 commits into
Conversation
## Changes - move stored/save/saved/kept helpers into `allow-query.ts` and `pickQuery` into `allow-prompt.ts`, keyed by `allow-skills` | `allow-scripts` - `editQuery` takes the key; per-key warning text - `vlt skills link`, install, update use them; output unchanged ## Tests - both keys; every `pickQuery` branch Co-authored-by: Ruy Adorno <ruy@vlt.sh>
## Changes - `vlt build [<query>]` builds and saves `allow-scripts` (positional, `--allow-scripts` or `VLT_ALLOW_SCRIPTS`); asks before replacing or editing a stored one, `-y` skips; `--config=user` saves to the user vlt.json - no query: stored `allow-scripts`, else `:scripts:not(:built):not(:malware)`; nothing stored, no TTY, no `-y`: built, not saved - `--target` / `command.build.target`: built as is, no prompt, never saved - saved only after a successful build; human/json output show it - docs: build page table + walkthrough, ci, configuring, migration ## Tests - every prompt table row, `--target`, env/flag query, failed build Co-authored-by: Ruy Adorno <ruy@vlt.sh>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bencher Report| Project | vltpkg |
| Branch | ruyadorno/build-allow |
| Testbed | ubuntu-latest |
Click to view all benchmark results
## Changes - `vlt install` / `vlt update` save an explicit `--allow-scripts` (or `VLT_ALLOW_SCRIPTS`) to the project vlt.json after success; another stored query is kept with a hint; `--lockfile-only` saves nothing - explicit query validated before installing - reporter + json show saved/kept allow-scripts - docs: install, configuring, build, migration from npm ## Tests - saved, same, kept, `:not(*)`, failed, lockfile-only, invalid query Co-authored-by: Ruy Adorno <ruy@vlt.sh>
ruy-bot
Bot
force-pushed
the
ruyadorno/build-allow
branch
from
October 20, 2026 05:30
47a6ea0 to
26e68a6
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vlt buildignoredallow-scriptsand saved nothing: a project neededcommand.build.targetfor builds plusallow-scriptsfor installs. Nowvlt build [<query>]sets, saves and appliesallow-scripts, prompting likevlt skills link;install/updatesave--allow-scripts.Fixes #2031
Changes
pickQuery, editor) keyed byallow-skills|allow-scripts;vlt skillsoutput unchangedvlt build [<query>]: query = positional,--allow-scriptsorVLT_ALLOW_SCRIPTS; issue's prompt table; default:scripts:not(:built):not(:malware); saved after a successful build to project vlt.json (--config=user→ user one)-y: default built, not saved--target/command.build.target: wins, built as is, never prompts or savesSaved allow-scripts="<q>" to vlt.json; jsonquery,savedvlt install/vlt update: explicit--allow-scriptsvalidated before installing, saved after success; another stored query kept w/ hint;ciand--lockfile-onlynever saveTests
--config=user, invalid query, failed build,--targetprecedence, env/flag as given:not(*), failed, lockfile-only, invalidpickQuery: every branch, both keys; skills command tests unchanged (editor calls gainkey)Follow-ups
:scripts:not(:built):not(:malware), so later installs run scripts of every unflagged pkg. Now warned; skip saving an unchanged default instead?command.build.targetin vlt.json silently wins overvlt build "<q>":<q>neither built nor saved. Warn?--allow-scripts/env both given: positional wins; confirmN/ctrl+C onReplace it?, or empty editor: nothing built--config=user), as--allow-skillsallow-scriptsnot validated byvlt build(build errors on it, as today)command.<cmd>.allow-scriptsblocks not treated as storedexec/create/init/uninstall--allow-scriptsnever saved--view=json(shared w/vlt skills link)vlt build" hint could mention savingCo-authored-by: Ruy Adorno ruy@vlt.sh