{{ message }}
Repository navigation
graph: draw every path to selected packages in query views - #2033
Open
ruy-bot[bot] wants to merge 1 commit into
Open
ruy-bot[bot] wants to merge 1 commit into
ruy-bot[bot] wants to merge 1 commit into
Conversation
`vlt query` mermaid/human views drew only some paths to a selection: mermaid's single reverse pass missed parents visited before their child got included; human view's repeat (seen) items never inherited inclusion. ## Changes - mermaid: propagate inclusion up all traversal parents (worklist) - human: an included item includes every item of its parent's node ## Tests - diamond graph (issue repro) draws both paths in both views - cycle: selecting `b` also draws back-edge `b → a` - snapshots: workspace paths that were dropped now drawn Fixes #2029 Co-authored-by: Ruy Adorno <ruy@vlt.sh>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bencher Report| Project | vltpkg |
| Branch | ruyadorno/query-paths |
| Testbed | ubuntu-latest |
Click to view all benchmark results
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vlt querymermaid/human views dropped extra paths to a selection (e.g.#msmissedagent-base > debug > ms). Inclusion now propagates up every parent to a fixpoint.Fixes #2029
Changes
vlt ls,vlt skills ls --view=mermaid, svg/png views (same renderers)Tests
balso draws back-edgeb → aactual graphroot lists onlyworkspace-asince test passesgraph.edges(no virtual ws edges) and only ws-a leads to selected deps (CLI adds virtual ws edges, unaffected)Follow-ups
#yin x↔y listsxundery). Kept closure rule (simple, deterministic, same as selected nodes today); simple-path-only filter is costly. Confirm OK.Co-authored-by: Ruy Adorno ruy@vlt.sh