{{ message }}
Repository navigation
package-info, graph: keep .tar.br integrity on store hits - #2011
Open
ruy-bot[bot] wants to merge 1 commit into
Open
ruy-bot[bot] wants to merge 1 commit into
ruy-bot[bot] wants to merge 1 commit into
Conversation
A `.tar.br` linked from the store with no pinned hash left lockfile integrity null, and `rm -rf node_modules && vlt i` never repaired it. A lockfile node with no hash also took the installed node's hash and url even when that was the other tarball kind, flipping `[4,…]` nodes to `.tgz`. Fixes #1995 ## Changes - package-info: on a store hit for an unpinned `.tar.br`, hash its cached bytes (if they match what was linked) so the lockfile gets one - graph: a reference node fills in integrity/resolved only when its tarball kind matches the lockfile flag bit ## Tests - package-info: store hit pins the hash (with and without a resolved url); missing or damaged cached body leaves it unset - graph: other-kind references ignored both ways, same-kind still used Co-authored-by: Ruy Adorno <ruy@vlt.sh>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bencher Report| Project | vltpkg |
| Branch | ruyadorno/br-integrity |
| Testbed | ubuntu-latest |
Click to view all benchmark results
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
.tar.brlinked from the store with no pinned hash left lockfile integrity null, andrm -rf node_modules && vlt inever repaired it. A lockfile node with no hash also took the installed node's hash and url even when that was the other tarball kind, flipping[4,…]nodes to.tgz.Fixes #1995
Changes
.tar.brhashes its cached bytes (if they match what was linked) so the lockfile gets oneTests
Follow-ups
vlt-lock.json;rm -rf node_modules && vlt idoesvlt-lock.json+ stale.tgznode_modules: actual graph seeds the ideal one, lockfile written as[0,…tgz]; kind still installer-dependent there.tgzwithoutdist.integritylinked from the store: integrity stays nullCo-authored-by: Ruy Adorno ruy@vlt.sh