{{ message }}
Repository navigation
Conversation
Extend the existing retention namespace instead of adding another backup switch. Preserve current draft-private values in place without restoring target-shared parameters, and allow empty draft wildcard selections. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
6 tasks done
Document the wildcard serving example and shared ownership rule in the existing retention section, rather than adding another configuration surface. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
Contributor
|
Documentation preview: https://vllm--61046.org.readthedocs.build/en/61046/ |
aoshen02
marked this pull request as ready for review
October 11, 2026 03:32
aoshen02
requested review from
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
njhill,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
October 11, 2026 03:32
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #94044 for commit |
Keep both retention use cases explicit and distinguish Engram inference-time CPU offload from level-2 sleep preservation. Use the narrow runtime table-and-scale pattern rather than selecting trainable Engram projections. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #94046 for commit |
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
Contributor
Author
|
/ci run |
Isotr0py
approved these changes
Oct 11, 2026
ZJY0516
approved these changes
Oct 11, 2026
This was referenced Oct 15, 2026
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
…vllm-project#61046) Signed-off-by: aoshen02 <aoshen@inferact.ai> Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
The existing
sleep_preserve_parameter_namesAPI preserves frozen Engram table weights and scales across level-2 sleep, without retransmitting them during target weight updates (#57891). Extend the same API to draft-private weights for target-only updates; both use cases are documented. Related: #52479.Claims
--sleep-preserve-parameter-names 'draft.*', or individualdraft.<name>patterns.Parameteridentities.draft.*selection (no draft, or no private parameters). Other unmatched patterns still raise.draft.*in the existing Sleep Mode section; preserve the distinction between retention and Engram inference-time CPU offload.Validation
Changed-file pre-commit passes. Focused CPU regression command:
The tests check shared ownership, in-place restoration, an absent/all-shared draft, and unmatched target names: baseline 3 failed, simplified pinned candidate 3 passed, main-based candidate 3 passed. Current-main base:
3c062d391d15cfa41d3f321cad24f3030c892a97. Tests used the experimental container's dependencies with current-main Python source; no kernels were exercised by these CPU tests.H200 model evaluation on the earlier equivalent nonempty-selection implementation, based on
43b4aaeawith the composed Vime patches:Six requests per phase; temperature 1, top-p 0.95, context 65,536, eager execution; model revision
1d4bf0f2ff6012fd82039f2fa52739d0dd7c60c0. This is not an otherwise-unpatched current-main GPU result. No throughput improvement or ROCm/CPU/XPU/all-drafter validation is claimed.The graph-enabled eight-GPU Agent training/rollout E2E also passes on the earlier
2ec58c52implementation in the installed experimental image: two training steps, maximum observed MTP acceptance 87.6%, mean acceptance length up to 3.63. This does not substitute for a clean current-main GPU test.Details
Level-2 sleep discards target and draft weights. Reloading only the target leaves draft-private storage undefined: verification still works, but speculative acceptance can disappear. This opt-in extension saves the current draft before sleep and restores it at weight wake, using the existing narrow no-grad restore helper. Draft-buffer handling is unchanged.
This is distinct from #52487 (restore a configured disk checkpoint during
reload_weights) and #60139 (explicitly load a new draft checkpoint). Neither retains the current draft across target-only IPC/NCCL updates. Those disk APIs remain useful and unchanged.The measured snapshot is approximately 203 MiB per rank for this model; CPU storage and copies occur only at sleep/wake. Retained parameters must not also be supplied by the weight-update sender, as with the existing retention API.
AI assistance was used for implementation, investigation, and validation. Submitted at the human maintainer's explicit request; kept as a draft for human line-by-line review, which is not asserted complete.
Pull Request Checklist
/pr-checklistskill. (Mandatory for agents, optional for humans).BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing