{{ message }}
Repository navigation
[CPU] Use pre-built triton - #58140
Merged
bigPYJ1151 merged 12 commits intoSep 24, 2026
Merged
Conversation
bigPYJ1151
force-pushed
the
worktree-triton-cpu-wheel
branch
from
September 22, 2026 11:00
2dc39ed to
530749c
Compare
Member
Author
… build The Dockerfile.cpu triton-cpu stage cloned triton-lang/triton-cpu and compiled it from a pinned commit on every CPU image build. v3.8.0 now publishes prebuilt manylinux wheels (per Python tag) on GitHub releases, so downloading the matching one is faster and removes the CMake/sleef submodule build entirely. requirements/cpu.txt gains matching platform/python-version-gated pins so a plain `pip install -r requirements/cpu.txt` on x86_64 also gets triton-cpu without a source build. Signed-off-by: jiang1.li <jiang1.li@intel.com>
…eel inline The dedicated build stage only ever downloaded a prebuilt release wheel (no compilation), so the extra stage plus bind-mount indirection was unnecessary. Instead, strip the transitive triton==3.6.0 pin from requirements/test/cpu.txt on x86 builds and install the triton-cpu wheel directly via uv pip install where it's needed (vllm-test-deps consumers: vllm-dev, vllm-test). vllm-openai needs no changes since it never installs requirements/test/cpu.txt and already gets triton-cpu via requirements/cpu.txt. Signed-off-by: jiang1.li <jiang1.li@intel.com>
…stall requirements/test/cpu.txt transitively pins a generic PyPI triton (via xgrammar) that clobbers the triton-cpu wheel from requirements/cpu.txt. Rather than sed-stripping that pin and manually re-downloading the triton-cpu wheel by hand-selecting its Python-version tag, just let the existing install steps fix it up: - vllm-test already runs `uv pip install dist/*.whl` after test/cpu.txt; the vllm wheel's install_requires (generated from requirements/cpu.txt by setup.py) already pins the same triton-cpu URL, so uv corrects it automatically. - vllm-dev has no such wheel-install step (it uses `setup.py develop`), so reinstall requirements/cpu.txt afterward to restore triton-cpu. - vllm-openai and vllm-test-deps need no changes. Signed-off-by: jiang1.li <jiang1.li@intel.com>
….txt Stripping requirements/test/cpu.txt's generic triton==3.6.0 pin (like the existing decord/terratorch handling for arm builds) is more direct than letting it clobber the triton-cpu wheel and then reinstalling requirements/cpu.txt to fix it back up. Since the pin is never applied, vllm-dev needs no corrective step at all. Signed-off-by: jiang1.li <jiang1.li@intel.com>
triton-cpu is a required CPU runtime dependency on x86_64 (see requirements/cpu.txt) that several CPU kernels quietly fall back from (spec decode, GDN mamba) via triton_utils.HAS_TRITON. Surface that expectation explicitly instead of only failing later inside individual kernels. Signed-off-by: jiang1.li <jiang1.li@intel.com>
Signed-off-by: jiang1.li <jiang1.li@intel.com>
Signed-off-by: jiang1.li <jiang1.li@intel.com>
|
✅ Triggered Buildkite CI #90418 for commit |
vllm bench sweep/mm-processor/plotting features need pandas, matplotlib, seaborn, datasets, scipy, plotly. Installing them at build time (by wheel path, alongside audio) avoids the uv URL-dependency error that installing "vllm[bench]" by name hits post-hoc, since triton is pinned via a direct URL in cpu.txt. Signed-off-by: jiang1.li <jiang1.li@intel.com>
…1151/vllm into worktree-triton-cpu-wheel
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #90627 for commit |
Member
Author
|
/ci run |
bigPYJ1151
marked this pull request as ready for review
September 24, 2026 06:57
jikunshang
approved these changes
Sep 24, 2026
4 tasks
4 tasks
5 of 7 tasks
1 task done
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
Signed-off-by: jiang1.li <jiang1.li@intel.com>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
Use public pre-built triton cpu
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.