{{ message }}
Repository navigation
[Bugfix] Fix np.float64 leaking into the KV transfer metrics log - #57068
Merged
NickLucche merged 4 commits intoSep 16, 2026
Merged
Conversation
reduce() in the nixl/mooncake/hf3fs connector stats returned numpy scalars (np.float64), violating the declared dict[str, int | float] contract. The single-connector log path hid this because f-strings use str(), but with a MultiConnector the reduced stats form a nested dict whose str() renders every value with repr(), so the CLI log showed np.float64(2.338) instead of 2.338. Convert the reduced values to plain Python scalars via .item(). Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai> Signed-off-by: NickLucche <nicolo.lucchesi@mistral.ai>
NickLucche
requested review from
ApostaC,
ivanium,
orozery and
xuechendi
as code owners
September 15, 2026 19:55
Member
Author
|
✅ Triggered Buildkite CI #89169 for commit |
Contributor
|
/ci run |
|
✅ CI is already running for this commit: https://buildkite.com/vllm/ci/builds/89169 |
Member
Author
|
/ci retry |
|
✅ The previous CI build is still running: https://buildkite.com/vllm/ci/builds/89169 |
Member
Author
|
/ci run |
NickLucche
enabled auto-merge (squash)
September 16, 2026 16:19
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
…m-project#57068) Signed-off-by: NickLucche <nicolo.lucchesi@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The KV transfer metrics log line currently shows raw numpy scalar reprs when the stats come from a connector inside a MultiConnector:
The single-connector path was fine because the log line formats each value with an f-string (
str()), which rendersnp.float64as a plain number. With a MultiConnector,reduce()returns a nested dict and the whole dict gets rendered withstr(), which formats every value withrepr()— and numpy 2 rendersrepr(np.float64(2.338))asnp.float64(2.338).The fix is to have the nixl/mooncake/hf3fs
reduce()implementations return plain Python scalars via.item(), which is what theirdict[str, int | float]annotation already promised. After the fix the same line reads:Assisted-by: Mistral Vibe