{{ message }}
Repository navigation
fix: validate Messages terminal event ordering - #402
Draft
franciscojavierarceo wants to merge 1 commit into
Draft
franciscojavierarceo wants to merge 1 commit into
franciscojavierarceo wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused validation changes match the documented protocol and include adequate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Enforces valid terminal ordering in Messages streams to prevent malformed rounds from dispatching tools or completing successfully.
Changes:
- Rejects
message_deltawhile content blocks remain open. - Rejects new content blocks after terminal deltas.
- Adds regression coverage and documents repeated usage snapshot behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Francisco Javier Arceo <arceofrancisco@gmail.com>
franciscojavierarceo
force-pushed
the
codex/messages-terminal-order
branch
from
October 9, 2026 00:39
043700c to
54faf0c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Reject Messages streams that interleave content blocks with terminal message deltas. A
message_deltawhile a block is open, or a new block after a message delta, now produces a fixedapi_errorbefore tool dispatch or successful completion. Previously, these invalid sequences could still execute a search.This follows the Messages streaming event flow: content blocks precede one or more message deltas. Repeated cumulative usage snapshots remain valid. The existing ingestion path and per-round state own both checks.
Part of #313 and Enterprise Readiness #316; follow-up to #396. Full schema validation and retained-resource limits remain open.
Test Plan
Reconciled with main after #411 merged. Retains all merged validation and extension-delivery assertions; the terminal-order guards are unchanged.