[RFC] dotnet-xunit support#249
Conversation
aignas
force-pushed
the
feature/csharp-xunit
branch
2 times, most recently
from
5370bf8 to
741b6b5
Compare
| " | ||
| "let file = a:position['file'] | ||
| "let project_path = test#csharp#get_project_path(file) | ||
| "let g:test#project_root = fnamemodify(project_path, ':p:h') |
There was a problem hiding this comment.
Does this commented out code need to remain?
There was a problem hiding this comment.
Not necessarily. At the moment there is a bug, that the pwd needs to be the same as the solution file and if you have sub-folders in the project and autochdir enabled, then it will not work unless you manually change the folder to the project root. I thought that setting it dynamically would work, but that does not work and it needs the changes that are introduced in #242 or something similar.
Shall I remove this commented out code and create an issue?
There was a problem hiding this comment.
Yes I think that would be better as commented out code can be a source of confusion. If you do create an issue you can add in the link in the comment block.
|
Thank you so much for your contribution, very much appreciated. Could you also update doc/test.txt with the test command please. |
aignas
force-pushed
the
feature/csharp-xunit
branch
from
5626447 to
1f0e723
Compare
codeinabox
left a comment
codeinabox
left a comment
There was a problem hiding this comment.
LGTM. @janko-m do you have any further feedback as this runner contains a fair bit of logic?
3 participants
This is initial support for the
dotnet-xunittool provided by the XUnit framework for C#.