{{ message }}
Add Racket's rackunit to vim-test#191
Merged
Merged
Conversation
Feature/add racket
codeinabox
approved these changes
May 23, 2017
codeinabox
left a comment
codeinabox
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this! Didn't know about Racket before today. Nothing wrong with it just supporting :TestFile
janko
approved these changes
May 23, 2017
janko
left a comment
janko
left a comment
Member
There was a problem hiding this comment.
Other than the few minor comments, looks good, thanks!
Member
There was a problem hiding this comment.
This function doesn't need to be defined, in other runners it's defined as a custom helper function for that specific runner, but here it's not used.
| \ 'Lua': ['Busted'], | ||
| \ 'PHP': ['Codeception', 'PHPUnit', 'Behat', 'PHPSpec', 'Kahlan', 'Peridot'], | ||
| \ 'Perl': ['Prove'], | ||
| \ 'Racket': ['Rackunit'], |
Member
There was a problem hiding this comment.
I would prefer if it was named RackUnit, that's what the command name would be if the user chooses to generate it.
Member
There was a problem hiding this comment.
Here you can also call it "RackUnit", since that's the official name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for Racket's built-in unit testing module, Rackunit.
Unfortunately a lot of the options available (running suites etc...) aren't available through the CLI meaning we can only really do :TestFile (hence the very slim PR)
Let me know if there are any problems.
Thanks! :D
Joe