{{ message }}
Conversation
Problem: set_indent() calls adjust_prop_columns() on every indent change
even when the buffer has no text properties, unlike all other
callers, wasting a memline unpack per line.
Solution: Guard the call with curbuf->b_has_textprop.
adjust_prop_columns() unpacks the memline entry for the line (um_open_at)
before it checks that there is nothing to adjust, so on a buffer without
text properties every ">", "<", "=" or autoindent paid for that unpack.
Every other caller guards the call with b_has_textprop; set_indent() was the
only one that did not.
Signed-off-by: Julien Voisin <julien.voisin@dustri.org>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: set_indent() calls adjust_prop_columns() on every indent change
even when the buffer has no text properties, unlike all other
callers, wasting a memline unpack per line.
Solution: Guard the call with curbuf->b_has_textprop.
adjust_prop_columns() unpacks the memline entry for the line (um_open_at) before it checks that there is nothing to adjust, so on a buffer without text properties every ">", "<", "=" or autoindent paid for that unpack. Every other caller guards the call with b_has_textprop; set_indent() was the only one that did not.