{{ message }}
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Tachi107
reviewed
Jan 20, 2025
chrisbra
force-pushed
the
gh-16327
branch
4 times, most recently
from
January 25, 2025 14:10
4b65ad8 to
3b35f38
Compare
chrisbra
added a commit
to chrisbra/vim
that referenced
this pull request
Jan 25, 2025
The terminfo database for xterm-direct contains both the (non-standard) termcap RGB capability and a number of colors == 0x1000000 so it seems either of those two options can be used to detect a terminal capable of displaying true colors. So set the termguicolor option automatically, when either of the two options is detected. (for some reasons, my debian xterm (v393) does not respond to XTGETTCAP query attempts, so falling back to the number of colors seems like a good compromize) fixes: vim#16327 closes: vim#16490 Signed-off-by: Christian Brabandt <cb@256bit.org>
The terminfo database for xterm-direct contains both the (non-standard) termcap RGB capability and a number of colors == 0x1000000 so it seems either of those two options can be used to detect a terminal capable of displaying true colors. So set the termguicolor option automatically, when either of the two options is detected. (for some reasons, my debian xterm (v393) does not respond to XTGETTCAP query attempts, so falling back to the number of colors seems like a good compromize) fixes: vim#16327 closes: vim#16490 Signed-off-by: Christian Brabandt <cb@256bit.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terminfo database for xterm-direct contains both the (non-standard) termcap RGB capability and a number of colors == 0x1000000 so it seems either of those two options can be used to detect a terminal capable of displaying true colors.
So set the termguicolor option automatically, when either of the two options is detected. (for some reasons, my debian xterm (v393) does not respond to XTGETTCAP query attempts, so falling back to the number of colors seems like a good compromize)