{{ message }}
Repository navigation
Conversation
vite arrives transitively through vitest and has been pinned at 4.0.4 since early 2023. osv-scanner reports 18 advisories against it; overriding to the latest 4.x clears 11 of them, including CVE-2025-31125, which CISA added to the Known Exploited Vulnerabilities catalogue on 2026-01-22. None of the 18 are reachable in this repository -- they are all Vite dev server issues and satori never starts one. This is dependency hygiene and scanner surface, not an incident. vite 4.5.14 resolves module ids more strictly than 4.0.4, which surfaces a latent issue in test/jsx-runtime.test.tsx: src/jsx has no jsx-dev-runtime, so the automatic runtime's dev variant has nothing to resolve to. The imports field in package.json maps both specifiers onto jsx-runtime.ts, but the test's relative @jsxImportSource bypasses that map. Setting esbuild.jsxDev = false keeps the transform on the production runtime. pnpm install / vitest run / tsup all clean: 55 suites, 512 tests, and the 498 image snapshots match without a single rewrite.
Contributor
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
vitereaches this repo transitively throughvitest, pinned at4.0.4since early 2023.osv-scannerreports 18 advisories against that version. Apnpm.overridespin to the latest 4.x clears 11, includingCVE-2025-31125, which CISA added to the Known Exploited Vulnerabilities catalogue on 2026-01-22.NOT URGENT
0/18 reachable in satori. They're all Vite dev server issues.
— CVE-2025-31125's text reads "Only apps explicitly exposing the Vite dev server to the network (using
--hostorserver.host) are affected."satori has no
vite.config.*, no--hostorserver.hostanywhere, (devistsup --watch; playground is Next.js).viteis absent fromdependencies.So: hygiene and scanner surface, not an incident. Worth doing mainly because anyone pointing an SCA scanner at satori currently gets a KEV-flagged hit, and the 4.5.x parser fixes are nice to have regardless.
The one non-obvious change
vite@4.5.14resolves module ids more strictly than4.0.4, which surfaces something latent intest/jsx-runtime.test.tsx.src/jsx/has nojsx-dev-runtime.ts— onlyjsx-runtime.ts. Theimportsfield maps both#satori/jsx/jsx-runtimeand#satori/jsx/jsx-dev-runtimeonto that one file, which is what makes the automatic runtime work. But the test uses a relative@jsxImportSource ../src/jsx, which bypasses the imports map, so the dev variant has nothing to resolve to. (The file's own// TODO: use #satori/jsx as import source after upgradine vitestlooks like it's about exactly this.)Setting
esbuild.jsxDev = falsekeeps the transform on the production runtime. Happy to do it another way if you'd prefer — adding the missingjsx-dev-runtime.ts, or moving the test onto#satori/jsx- I went for lowest touch.What this deliberately leaves
Seven advisories remain, as none has a fix in the 4.x line: CVE-2025-58751, CVE-2025-58752 (
<5.4.20), CVE-2024-52011 (<5.4.9), CVE-2025-62522 (<5.4.21), CVE-2026-39365 (<6.4.2), CVE-2026-53571, CVE-2026-53632 (<6.4.3). Four are Windows-only. Reaching them needs vite ≥ 6.4.3, outsidevitest@0.32's peer range — so it means upgrading vitest too. I've put that on a separate branch and opened it as #793, but I don't recommend merging it as-is and that PR explains why. The same non-exploitability applies to all seven.Verification
pnpm install/pnpm test/pnpm build:default— all clean; 55 suites, 512 testsNode floor,
dependencies,filesand the published artefact are unchanged. Since nothing shipped changes I usedchore(deps):so it shouldn't cut a release — say the word if you'd rather it werefix:.