{{ message }}
Suite cache should not be saved for packages that are not suites#1313
Merged
Suite cache should not be saved for packages that are not suites#1313
Conversation
Contributor
…` are getting populated even package is not a suite.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1313 +/- ##
===========================================
+ Coverage 95.04% 95.08% +0.03%
===========================================
Files 111 111
Lines 5369 5369
Branches 33 33
===========================================
+ Hits 5103 5105 +2
+ Misses 266 264 -2 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lwasylow
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in
ut_suite_cache_managerthat was causing packages that had comments captured as annotations ( the--%) to be saved in suite cache and considered as test suites.Those packages were then getting excluded form coverage report.
Only packages that contain suite information should be considered test suites and should eb added to suite cahge.
The annotation parsing remains independent from suite constriction and therefore all lines with comment
--%are still saved in annotation cache.Resolves #1278