{{ message }}
Repository navigation
fix(yaml): pass keyonly condition with searchpattern when at least one file matches - #9889
Merged
olblak merged 4 commits intoAug 12, 2026
Merged
Conversation
…e file matches When a yaml condition uses searchpattern with keyonly, it should pass as long as at least one matched file contains the specified key, aligning with the file plugin behavior. Previously the condition failed whenever any matched file did not contain the key. Also record a per-file key miss for the yamlpath engine so the searchpattern handling can distinguish 'at least one file contains the key' from 'no file contains it'. Closes updatecli#9848 Signed-off-by: Junhuan Zheng <3373484735@qq.com>
Contributor
Author
olblak
reviewed
Aug 7, 2026
olblak
left a comment
olblak
left a comment
Member
There was a problem hiding this comment.
Thanks, this looks great, I'll need to find some time to test it
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Author
olblak
approved these changes
Aug 11, 2026
olblak
left a comment
olblak
left a comment
Member
There was a problem hiding this comment.
Thanks for the pullrequest, tested manually and it works as expected
olblak
enabled auto-merge (squash)
August 11, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9848
When a yaml condition uses
searchpattern: truetogether withkeyonly: true, it should pass as long as at least one matched file contains the specified key, aligning with the file plugin behavior. Previously the condition failed whenever any matched file did not contain the key.This change also records a per-file key miss for the
yamlpathengine so the searchpattern handling can distinguish "at least one file contains the key" from "no file contains it".Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement