fix(core): generate reportID before templating by olblak · Pull Request #10664 · updatecli/updatecli · GitHub
Skip to content

fix(core): generate reportID before templating - #10664

Merged
olblak merged 3 commits into
updatecli:mainfrom
olblak:fix/stable-report-id
Sep 29, 2026
Merged

olblak merged 3 commits into
updatecli:mainfrom
olblak:fix/stable-report-id

Conversation

@olblak

@olblak olblak commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

This pullrequest fix a situation where Updatecli would creates different report id for a same manifest using different dynamic values like in the autodiscovery situation

Test

To test this pull request, you can run the following commands:

cd pkg/core/pipeline
go test

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.
  • I have tested this pull request manually with a custom Updatecli build and it works as expected.

Tradeoff

Potential improvement

Summary by CodeRabbit

  • Improvements
    • Report IDs remain stable when runtime-rendered values change during a pipeline run, while still reflecting the pipeline’s configured resources.
    • When configuration details cannot be extracted normally, available resource configuration is used to calculate the report ID.
    • Resource IDs continue to reflect their current configuration, even when the report ID is frozen.
    • Reports without a frozen ID continue to use the existing ID behavior, and reports without templates retain their existing ID.

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the bug Something isn't working label Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Signed-off-by: Olblak <me@olblak.com>
@olblak
olblak merged commit 83a8bd0 into updatecli:main Sep 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant