{{ message }}
Repository navigation
fix: allow to use dynamic info in pipeline name #10510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6bbc323
fix: allow to use dynamic info in pipeline name
olblak af4d94b
Merge branch 'main' into fix/pipeline/name
olblak 13f4bed
fix: logic
olblak 76ef7ae
fix: unrendered pipeline name used for pipelineid
olblak 2c61e6c
fix: empty pipeline name
olblak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| package pipeline | ||
|
|
||
| import ( | ||
| "crypto/sha256" | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "github.com/updatecli/updatecli/pkg/core/config" | ||
| "github.com/updatecli/updatecli/pkg/core/pipeline/source" | ||
| "github.com/updatecli/updatecli/pkg/core/result" | ||
| ) | ||
|
|
||
| func TestUpdateRefreshesName(t *testing.T) { | ||
| testdata := []struct { | ||
| name string | ||
| sourceResult string | ||
| expectedName string | ||
| }{ | ||
| { | ||
| name: "source succeeded", | ||
| sourceResult: result.SUCCESS, | ||
| expectedName: "deps(go): bump module golang.org/x/net to v0.38.0", | ||
| }, | ||
| { | ||
| name: "source skipped keeps the placeholder", | ||
| sourceResult: result.SKIPPED, | ||
| expectedName: `deps(go): bump module golang.org/x/net to {{ source "fixed" }}`, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range testdata { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| rawName := `deps(go): bump module golang.org/x/net to {{ source "fixed" }}` | ||
|
|
||
| p := Pipeline{ | ||
| ID: "pipeline-id", | ||
| Config: &config.Config{ | ||
| Spec: config.Spec{ | ||
| Name: rawName, | ||
| PipelineID: "pipeline-id", | ||
| }, | ||
| }, | ||
| Sources: map[string]source.Source{ | ||
| "fixed": { | ||
| Result: &result.Source{Result: tt.sourceResult}, | ||
| Output: "v0.38.0", | ||
| }, | ||
| }, | ||
| } | ||
| p.Report.Name = rawName | ||
|
|
||
| require.NoError(t, p.Update()) | ||
|
|
||
| assert.Equal(t, tt.expectedName, p.Name) | ||
| assert.Equal(t, tt.expectedName, p.Report.Name) | ||
| assert.Equal(t, "pipeline-id", p.ID) | ||
| assert.Equal(t, "pipeline-id", p.Config.Spec.PipelineID) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // TestActionReportIDIgnoresRenderedName ensures the action report ID doesn't change when the pipeline name | ||
| // is rendered, so pullrequest reports created before and after a version change are merged together. | ||
| func TestActionReportIDIgnoresRenderedName(t *testing.T) { | ||
| rawName := `deps(go): bump module golang.org/x/net to {{ source "fixed" }}` | ||
|
|
||
| p := Pipeline{} | ||
| require.NoError(t, p.Init(&config.Config{ | ||
| Spec: config.Spec{ | ||
| Name: rawName, | ||
| PipelineID: "pipeline-id", | ||
| }, | ||
| }, Options{})) | ||
|
|
||
| p.Sources["fixed"] = source.Source{ | ||
| Result: &result.Source{Result: result.SUCCESS}, | ||
| Output: "v0.38.0", | ||
| } | ||
| require.NoError(t, p.Update()) | ||
|
|
||
| require.Equal(t, "deps(go): bump module golang.org/x/net to v0.38.0", p.Name) | ||
| assert.Equal(t, fmt.Sprintf("%x", sha256.Sum256([]byte(rawName))), p.actionReportID()) | ||
| } | ||
|
|
||
| func TestActionReportIDWithoutInit(t *testing.T) { | ||
| p := Pipeline{Name: "pipeline"} | ||
|
|
||
| assert.Equal(t, fmt.Sprintf("%x", sha256.Sum256([]byte("pipeline"))), p.actionReportID()) | ||
| } | ||
|
|
||
| // TestInitNameFallsBackToTitle ensures a specification defining only a title exposes that title | ||
| // as both the pipeline name and the report name, including before the configuration is rendered. | ||
| func TestInitNameFallsBackToTitle(t *testing.T) { | ||
| p := Pipeline{} | ||
| require.NoError(t, p.Init(&config.Config{ | ||
| Spec: config.Spec{ | ||
| Title: "Bump golang.org/x/net", | ||
| PipelineID: "pipeline-id", | ||
| }, | ||
| }, Options{})) | ||
|
|
||
| assert.Equal(t, "Bump golang.org/x/net", p.Name) | ||
| assert.Equal(t, "Bump golang.org/x/net", p.Report.Name) | ||
|
|
||
| require.NoError(t, p.Update()) | ||
|
|
||
| assert.Equal(t, "Bump golang.org/x/net", p.Name) | ||
| assert.Equal(t, "Bump golang.org/x/net", p.Report.Name) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

Uh oh!
There was an error while loading. Please reload this page.