{{ message }}
Repository navigation
Conversation
37d3b6f started passing current_subject positionally into openai_chat_completions from the /v1/responses adapter, and the five fake_chat_completions stubs in test_responses_tool_passthrough.py still took (chat_req, request), so all 15 tests driving the adapter died on arity before asserting anything. Backend CI has been red on main since. Accept the third argument.
Contributor
Author
This was referenced Aug 29, 2026
Contributor
Author
|
Status across the four repair PRs (#9949, #9956, #9957, #9958): each fixes one of the families keeping Backend CI's 3.13 leg red, so each still inherits the other three and none can show a green leg alone — together they green it (verified per-family on this leg's own runs). If a single combined PR is easier to review and merge, say the word and I'll stack the four into one branch — otherwise they merge cleanly in any order. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backend CI has been red on main for ~20 consecutive runs. One of the two failure families is 15 tests in
test_responses_tool_passthrough.pydying on arity:Cause
37d3b6f (#8768) made the
/v1/responsesadapter passcurrent_subjectpositionally intoopenai_chat_completions, but the fivefake_chat_completionsstubs in this file still take(chat_req, request), so every test that drives the adapter dies before asserting anything.Fix
Accept the third argument in the five stubs. Test-side only — the production call is correct (other patchers in the suite, e.g.
test_chat_generation_supervisor.pyandtest_active_generations.py, already pass or accept the subject).Verification
test_responses_tool_passthrough.py: 15 failed → 117 passedtest_chat_generation_supervisor,test_active_generations,test_api_profile_usage_routes): 235 pass togetherNot in this PR
The other red family on main — 8
test_openai_auto_switch.pyfailures from the same #8768 (gguf_onlycapture KeyErrors and_host_has_a_non_gguf_backendprobing realfind_spec("torch")in a torch-less CI env) — needs per-test care; happy to follow up separately.