{{ message }}
Format the mmproj placement policy tests so pre-commit stops failing every PR - #9414
Merged
Conversation
…every PR The ruff-format-with-kwargs hook rewrites this file, so pre-commit.ci reports 'files were modified by this hook' and fails. It fails on main itself, which means it fails on every open pull request whose merge includes main, whatever that pull request changed: 9400 changes four TypeScript files and no Python at all, and still fails this check. Reproduced on a clean worktree at origin/main by running the hook's own entry point over every Python file it selects. Exactly one file comes back modified, this one, introduced by #9063 and last touched by #9383. The change is formatting only: two signatures rejoined onto one line, one call rejoined, and one blank line after an import removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Run the repo's own
ruff-format-with-kwargshook overstudio/backend/tests/test_mmproj_placement_policy.py. Formatting only: two test signaturesrejoined onto one line, one call rejoined, and one blank line after a function-local import
removed.
Why
pre-commit.cicurrently fails onmain, so it fails on every open pull request whose mergeincludes
main, regardless of what that pull request changes. #9400 changes four TypeScript filesand no Python at all, and still fails this check.
The hook's failure mode is "files were modified by this hook", and one modified file is enough to
fail the whole run, so the result reads as a repo-wide formatting problem when it is a single file.
How this was pinned down
On a clean worktree at
origin/main, running the hook's own entry point over every Python file itselects (
git ls-files '*.py'minus the hook'sexcludepattern, 3,000-odd files) leaves exactlyone file modified:
The file arrived in #9063 and was last touched by #9383.
Checks
ruff checkon the file: all checks passed