Fix Qwen3.8 presence penalty defaults by Imagineer99 · Pull Request #9372 · unslothai/unsloth · GitHub
Skip to content

Fix Qwen3.8 presence penalty defaults - #9372

Merged
danielhanchen merged 6 commits into
unslothai:mainfrom
Imagineer99:fix/qwen38-presence-penalty-defaults
Aug 20, 2026
Merged

Fix Qwen3.8 presence penalty defaults#9372
danielhanchen merged 6 commits into
unslothai:mainfrom
Imagineer99:fix/qwen38-presence-penalty-defaults

Conversation

@Imagineer99

@Imagineer99 Imagineer99 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Give Qwen3.8 the same backend sampling defaults as Qwen3.6.
  • Keep presence_penalty=1.5 in both thinking and non-thinking modes.
  • Share one frontend Qwen sampling resolver between post-load and Think-toggle paths.
  • Leave generic Qwen3 defaults unchanged.

preserve_thinking remains default-on from #9096.

Why

Qwen3.8 previously fell through to the generic Qwen3 defaults, so Studio did not apply the intended presence penalty. This explicitly maps Qwen3.8 to the Qwen3.6 defaults and keeps both frontend update paths consistent.

Validation

  • Backend sampling resolution: 31 passed.
  • Complete frontend Node suite: 4,083 passed.
  • Frontend TypeScript typecheck passed.
  • Changed frontend logic/tests passed ESLint.
  • git diff --check passed.

@Imagineer99
Imagineer99 marked this pull request as ready for review August 20, 2026 10:42
@Imagineer99 Imagineer99 changed the title Default Qwen3.8 sampling like Qwen3.6 Fix Qwen3.8 presence penalty defaults Aug 20, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 455cf91b55

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread studio/backend/assets/configs/inference_defaults.json
Comment thread studio/frontend/src/features/chat/utils/qwen-params.ts
@Imagineer99

Copy link
Copy Markdown
Collaborator Author

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 9c76c56962

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a97bdeb29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread studio/frontend/src/features/chat/lib/apply-inference-status-to-store.ts Outdated
@Imagineer99

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

@danielhanchen
danielhanchen merged commit 9574476 into unslothai:main Aug 20, 2026
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants