Show activity on a 0-byte Xet download and keep finished cards visible longer - #9303
Conversation
1 similar comment
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05ada245d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05ada245d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {indeterminate | ||
| ? "Transferring…" |
There was a problem hiding this comment.
When a user cancels before the first byte is measured, DownloadRow continues rendering this component because its active condition includes cancelling. The zeroed progress therefore renders an animated bar labeled Transferring… directly above the Cancelling… status until the backend confirms cancellation (or the watchdog expires), misleading users that the requested cancellation did not stop the transfer. Pass the job state through or suppress the indeterminate transfer state while cancellation is pending.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 72550c5. Confirmed: DownloadRow renders the bar while state is "cancelling" (active = running || cancelling) and StatusLine prints "Cancelling..." directly below it, so a zero-byte cancel showed an animated "Transferring..." above "Cancelling...".
isIndeterminateProgress now takes a cancelling flag and returns false when set, so the row falls back to the measured reading. Passed through at all three call sites: the manager panel (job.state === "cancelling"), the catalog download card (job.cancelling), and the Voice settings tab (sttDownloadCancelling), since the catalog card renders its own "Cancelling..." label too. Regression test added; it fails without the change and passes with it.
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 participants
Xet commits bytes in batches, so a download that finishes fast reads 0 B its whole life, then the completed card removes itself 6s later on a fast connection it looks like the download showed no progress and disappeared (the #9159 report). Render an indeterminate bar with "Transferring…" until the first measured byte, and keep completed cards for 30s.