{{ message }}
Revert "Say why a Xet download sits at 0% until it finishes" - #9293
Merged
Conversation
This reverts commit 3bf9bff.
This was referenced Aug 25, 2026
danielhanchen
added a commit
that referenced
this pull request
Aug 25, 2026
The measured pair showed the shortened toast clearing the toolbar, but only just. At 149 characters it rendered 114.5px tall, bottom edge at y=126.5, against a hub filter row whose centre sits at y=127. Every control hit-tested as clickable, so the check passed, by half a pixel. A longer translation, a different font stack or a zoom level would have put it back over the row and re-broken what #9293 reverted. At 101 characters the toast ends near y=100 and does not reach the row at all, so the result stops depending on sub-pixel layout. The budget in the tests drops from 170 to 110, which now rejects the 149-char version rather than accepting it. The transport control is two clicks away in Model Hub and discoverable without being told. A toast that eats the toolbar is not worth it.
danielhanchen
added a commit
that referenced
this pull request
Aug 25, 2026
…lbar (#9658) * Reapply "Say why a Xet download sits at 0% until it finishes (#9159)" (#9293) This reverts commit e326033. * Shrink the Xet notice so it clears the hub toolbar The notice itself was fine. Its size was not: 62 characters of title and 330 of description rendered 235px tall in the top-right corner, which is where the Model hub keeps its own toolbar. While the toast was up the capability filter, the sort dropdown, the Models and Datasets tabs and the repo action icons sat underneath it. Hit testing each control's own centre point put 4 to 6 of them inside the toast, so they could not be clicked, three times per install at 8s each. That is what #9293 reverted. Title is now 19 characters and the description 149, in plain language and one paragraph, which drops the pre-line class the old blank line needed. The character budget is asserted in the tests rather than left as a convention, since the failure is invisible to unit tests and to a screenshot taken at the wrong viewport. * Drop the HTTP hint: it left a 0.5px margin, not a margin The measured pair showed the shortened toast clearing the toolbar, but only just. At 149 characters it rendered 114.5px tall, bottom edge at y=126.5, against a hub filter row whose centre sits at y=127. Every control hit-tested as clickable, so the check passed, by half a pixel. A longer translation, a different font stack or a zoom level would have put it back over the row and re-broken what #9293 reverted. At 101 characters the toast ends near y=100 and does not reach the row at all, so the result stops depending on sub-pixel layout. The budget in the tests drops from 170 to 110, which now rejects the 149-char version rather than accepting it. The transport control is two clicks away in Model Hub and discoverable without being told. A toast that eats the toolbar is not worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reverts #9159