{{ message }}
Give the llama-flag fixtures the parallelSlotsClamped they now require - #8837
Merged
oobabooga merged 1 commit intoAug 14, 2026
Merged
Conversation
2098b7c added parallelSlotsClamped as a required field of LlamaFlagCatalog and set it in both real parsers, but four fixtures in llama-extra-args-diagnostics.test.ts still build the catalogue by hand without it, so `npm run typecheck` fails on main: tests/llama-extra-args-diagnostics.test.ts(20,7): error TS2741: Property 'parallelSlotsClamped' is missing in type '{ ... }' but required in type 'LlamaFlagCatalog'. ... and the same at 113, 902 and 922 Frontend CI runs that script on pushes to main, so the gate is red for everyone until the fixtures catch up. false is the value the real parsers use when the backend does not report the field, and its comment there calls it the safe read, so it is what these fixtures mean. Also pin the field in the interface contract test beside defaultParallelSlots. Both are read off the same probe and go stale the same way, and the assertion next to it already exists for exactly that reason; had it covered both, this would have failed as a test rather than as a typecheck.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
npm run typecheckfails onmainright now:2098b7cd4("Add an extra llama-server arguments box to the model settings", #8702) addedparallelSlotsClampedas a required field ofLlamaFlagCatalogand set it in both real parsers, but four fixtures inllama-extra-args-diagnostics.test.tsbuild the catalogue by hand and were not updated.studio-frontend-ci.ymlrunsnpm run typecheckon pushes tomain, so the Frontend CI gate is red for everyone until the fixtures catch up. The three most recent runs onmainare failing.Fix
Two parts, both small.
1. The four fixtures get the field.
falseis what the real parsers use when the backend does not report it, and the comment there calls it the safe read:so
falseis what these fixtures mean: an unprobed or older build, which is exactly the scenario each of them is testing.2. The interface contract test pins the field, next to the assertion that already pins
defaultParallelSlots:Both fields are read off the same
--helpprobe and go stale together, which is the reason the neighbouring assertion exists. Had it covered both, this would have surfaced as a failing test rather than as a broken typecheck.Test
The new contract assertion was checked to actually bite, not just to pass: renaming both declarations of
parallelSlotsClamped: boolean;inllama-flags.tstakes the file from 66 passed to 65 passed / 1 failed with(Renaming only the first declaration is not enough, since the field is declared twice in that file, which is worth knowing if anyone re-checks this.)
Nothing outside the test file changes.