Repository navigation
Tests: follow #14473's Unsloth wording in the sandbox, xformers and autoopt parity checks - #14522
Conversation
…utoopt parity checks
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
1 participant
Problem
#14473 renamed user-facing "Studio" to "Unsloth" in the backend messages, but three tests still expect the old wording. They fail on main and on open PRs (for example #14494 and #14488):
test_sandbox_linux.py::test_an_interpreter_symlinked_out_of_the_workdir_fails_the_callPython that runs StudioPython that runs Unsloth(sandbox_linux.py)test_diffusion_attention.py::test_a_hidden_xformers_is_not_reinstalled_in_the_same_processrestart Studiorestart Unsloth(diffusion_attention.py)test_diffusion_autoopt_parity.py(two tests)the Studio fast step that replays decode steps from tensors, 16 times infixtures/diffusion_autoopt_parity.jsonthe Unsloth fast step ...(diffusion_capture_safe.py)The rename was intended, so the tests are what is out of date.
Fix
Test only. Both assertions and the 16 recorded reasons in the parity fixture now use "Unsloth". Those 16 strings were the only "Studio" in the fixture. Nothing else in it changes.
Verification
test_sandbox_linux.pyandtest_diffusion_attention.py: both target tests fail on main and pass with this change.test_active_attention_backend_reads_tuple_return, is anImportErrorfrom this host'shuggingface_huband fails the same way on main.test_diffusion_autoopt_parity.py(CPU torch 2.10, diffusers 0.41.0.dev0):