{{ message }}
Repository navigation
Fix main's red CI after #14437, #14455 and #14473 - #14517
Merged
Merged
Conversation
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Five checks fail on main, so the
Repo tests (CPU, studio),Repo tests (CPU, rest)andworkflow-trigger lintshards are red on every open PR (for example #14472, #14482, #14488, #14490 and #14494). All five reproduce on main4d7ebf5cea.tests/security/test_lint_risky_loaders.py::test_the_tree_matches_the_baselineimport_moduleinstudio/backend/core/rag/embeddings.py, and a thirdimport_from_stringinunsloth/models/sentence_transformer.py(_require_word_tokenizer). Both are safe, see below.tests/studio/test_tauri_branding_contract.py::test_desktop_surfaces_do_not_restore_studio_brandingtests/studio/test_usage_examples_model_source_contract.py::test_auto_switch_section_sits_above_the_usage_examplesapi-settings-tab.test.tspins that.tests/studio/test_usage_examples_model_source_contract.py::test_monitor_can_unload_the_loaded_modelApiModelLoadControls). The/unloadpath itself is unchanged.tests/studio/test_settings_compact_overflow_contract.py::test_api_monitor_entries_and_expanded_text_can_shrinkborder-b), and the prompt/reply box'srounded-lgbecame conditional, so the class literals the test matched are gone. The overflow guards themselves are still in the source.Fix
embeddings.pyimports only the threesentence_transformers.modelspaths written out in a literal tuple, to wrap theirimport_from_stringwith the trust gate._require_word_tokenizerimports only after its caller has refused anytokenizer_classoutsidesentence_transformers.*, and only dotted identifiers.conversation-markdown-import.test.tsnow matches/Unsloth Markdown/.unloadActiveModelto the load controls asonUnloadActive, and eject is withheld whilebusy(modelLoading || unloading, feat(studio): add model picker and reload shortcut to API monitor #11223's rule);/unloadcall still reads the internal id from status;w-full min-w-0;max-h-72 overflow-auto break-words;min-w-0 break-all.Verification
studio/frontend/tests/conversation-markdown-import.test.ts: 20 passed.min-w-0from the entry row, orbreak-wordsfrom the text box: the overflow test fails;unloadingfrombusy, or passingonEjectwhile busy: the unload test fails;