{{ message }}
fix: Cancel click on touch long-press menu#23596
Draft
MartinZikmund wants to merge 2 commits into
Draft
Conversation
On Skia targets, long-pressing a control (e.g. a Button) with a ContextFlyout both opened the menu AND raised Click, instead of behaving like a right-tap. WinUI suppresses the click because opening the menu's popup steals the OS pointer capture (PointerCaptureLost); Uno's in-canvas popups don't, so the pressed state was never cleared. When a context menu is shown on a touch press-and-hold, release the pressing element's pointer capture and raise an unhandled PointerCaptureLost so the control clears its pressed state and does not click on release. fixes #22229 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQEkhvePgnJMns2KhVNUxr
On touch devices the browser starts a text-selection gesture on long-press, firing a haptic buzz and selection/callout UI before the cancelable 'contextmenu' event - so preventing the context menu does not stop the buzz, and it conflicts with the app's own press-and-hold gestures (e.g. opening a ContextFlyout). Uno Skia draws all text and selection with Skia, so the browser selection is never useful. Disable it (and the long-press callout) on the app root via user-select/-webkit-touch-callout, and re-enable selection on the hidden IME input so text editing keeps working. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQEkhvePgnJMns2KhVNUxr
github-actions
Bot
added
the
platform/wasm 🌐
Contributor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /// Releases the explicit pointer capture and raises an <em>unhandled</em> PointerCaptureLost so the | ||
| /// pressing control clears its pressed state. Used when a context menu is shown on a touch press-and-hold: | ||
| /// WinUI clears the pressed state via the OS pointer-capture-changed raised when the menu's popup steals | ||
| /// capture, but Uno's popups don't, so we do it explicitly (issue #22229). |
Contributor
There was a problem hiding this comment.
Minor style (AGENTS.md): "Don't reference the current task, fix, or callers ('handles the case from issue #123') since those belong in the PR description and rot as the codebase evolves." Remove (issue #22229) from the prose; the [GitHubWorkItem] annotations on the tests are the right place for that cross-reference.
Suggested change
| /// capture, but Uno's popups don't, so we do it explicitly (issue #22229). | |
| /// Releases the explicit pointer capture and raises an <em>unhandled</em> PointerCaptureLost so the | |
| /// pressing control clears its pressed state. Used when a context menu is shown on a touch press-and-hold: | |
| /// WinUI clears the pressed state via the OS pointer-capture-changed raised when the menu's popup steals | |
| /// capture, but Uno's popups don't, so we do it explicitly. |
| /// gesture, raising PointerCaptureLost so the pressing element (e.g. a Button) clears its pressed | ||
| /// state and does not raise Click/Tapped on release (issue #22229). | ||
| /// </summary> | ||
| private void ReleaseContextMenuHoldingPointerCapture() |
Contributor
There was a problem hiding this comment.
Same minor style issue — (issue #22229) in the doc comment body. Drop it; issue context lives in the commit message and PR description, not in code prose.
Suggested change
| private void ReleaseContextMenuHoldingPointerCapture() | |
| /// Releases the explicit pointer capture held for the touch pointer that triggered the holding | |
| /// gesture, raising PointerCaptureLost so the pressing element (e.g. a Button) clears its pressed | |
| /// state and does not raise Click/Tapped on release. |
| { | ||
| foreach (var capture in captures) | ||
| { | ||
| if (capture.Pointer.PointerId == _contextMenuOnHoldingPointerId |
Contributor
There was a problem hiding this comment.
When SetContextMenuOnHoldingPointer is never called (e.g. a code path that calls RaiseContextRequestedEvent with isTouchInput: true but skips SetContextMenuOnHoldingPointer), _contextMenuOnHoldingPointerId is 0. Iterating all captures looking for pointer ID 0 is harmless in practice (no real pointer uses ID 0), but an explicit early-return makes the invariant clear:
Suggested change
| if (capture.Pointer.PointerId == _contextMenuOnHoldingPointerId | |
| private void ReleaseContextMenuHoldingPointerCapture() | |
| { | |
| if (_contextMenuOnHoldingPointerId == 0) | |
| { | |
| return; | |
| } | |
| if (PointerCapture.Any(out var captures)) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Skia targets, long-pressing a control (e.g. a Button) with a
ContextFlyout both opened the menu AND raised Click, instead of
behaving like a right-tap. WinUI suppresses the click because opening
the menu's popup steals the OS pointer capture (PointerCaptureLost);
Uno's in-canvas popups don't, so the pressed state was never cleared.
When a context menu is shown on a touch press-and-hold, release the
pressing element's pointer capture and raise an unhandled
PointerCaptureLost so the control clears its pressed state and does not
click on release.
fixes #22229
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01WQEkhvePgnJMns2KhVNUxr**GitHub Issue:** closes #
PR Type:
What changed? 🚀
PR Checklist ✅
Screenshots Compare Test Runresults.