{{ message }}
fix(dedupeImports): use original array index to avoid offset with disabled imports#510
Open
guoyangzhen wants to merge 1 commit intounjs:mainfrom
Open
fix(dedupeImports): use original array index to avoid offset with disabled imports#510guoyangzhen wants to merge 1 commit intounjs:mainfrom
guoyangzhen wants to merge 1 commit intounjs:mainfrom
Conversation
…abled imports Fixes unjs#505
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #505
Problem
dedupeImportsusedimports.filter(i => !i.disabled).forEach((i, idx) => ...)whereidxis the index in the filtered array. ButindexToRemovestores these filtered indexes and applies them to the original array viaimports.filter((_, idx) => !indexToRemove.has(idx)).When disabled imports exist, all indexes are offset. For example:
Fix
Iterate the original array directly and skip disabled items with
return. This ensuresidxalways matches the original array position.Summary by CodeRabbit