{{ message }}
fix: isJSONSerializable returns true for null (#571)#596
Open
rafaumeu wants to merge 1 commit into
Open
Conversation
Fixes unjs#571 The bug was on line 22 where it checked `t === null`, but typeof never returns "null" (typeof null === "object"). This caused: 1. Dead code: t === null was always false 2. isJSONSerializable(null) threw TypeError accessing null.buffer 3. null was incorrectly identified as not JSON serializable Fixed by: - Adding explicit null check before typeof comparison - Removing t === null from typeof checks (impossible condition) Tests: - Added comprehensive unit tests for isJSONSerializable - All tests pass including null, undefined, primitives, and edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #571
Bug Description:
The function had a critical bug on line 22 where it checked
t === null,but
typeofnever returns "null" (typeof null === "object").This caused three issues:
t === nullwas always falseisJSONSerializable(null)threw TypeError: "Cannot read properties of null (reading buffer)"Changes:
value === nullcheck before typeof comparisont === nullfrom typeof checks (impossible condition)Testing:
Summary by CodeRabbit
Bug Fixes
Tests