fix: export types from `node` export condition by danielroe · Pull Request #407 · unjs/ofetch · GitHub
Skip to content

fix: export types from node export condition#407

Merged
pi0 merged 1 commit into
mainfrom
fix/node-type-exports
Jun 20, 2024
Merged

fix: export types from node export condition#407
pi0 merged 1 commit into
mainfrom
fix/node-type-exports

Conversation

@danielroe

Copy link
Copy Markdown
Member

Looking at resolving type issues in nuxt/nuxt#27702, it seems we don't have types exported from node declarations in ofetch, which means they can't be resolved/imported in some environments.

@danielroe danielroe added the bug Something isn't working label Jun 20, 2024
@danielroe danielroe requested a review from pi0 June 20, 2024 19:21
@danielroe danielroe self-assigned this Jun 20, 2024
@pi0 pi0 changed the title fix: export types from node declaration fix: export types from node export condition Jun 20, 2024
@pi0 pi0 merged commit 8d6d913 into main Jun 20, 2024
@pi0 pi0 deleted the fix/node-type-exports branch June 20, 2024 19:24
danielroe added a commit to nuxt/nuxt that referenced this pull request Jun 20, 2024
@pi0 pi0 mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants