Codecov Report

❌ Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.78%. Comparing base (f249a3c) to head (16fda28).
⚠️ Report is 30 commits behind head on dev/v4-fin.

@@               Coverage Diff               @@
##           dev/v4-fin     #467       +/-   ##
===============================================
+ Coverage       39.76%   65.78%   +26.01%     
===============================================
  Files              12       12               
  Lines            2253     2274       +21     
===============================================
+ Hits              896     1496      +600     
+ Misses           1357      778      -579     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Greptile Summary

This PR adds two testnet networks (sepolia, chain ID 11155111, and unichain_sepolia, chain ID 1301) to the V4 contract address maps, and refactors the Uniswap4 constructor to load each contract inside its own try/except NameNotFound block so that a missing address on a given network doesn't abort the entire object construction.

• Testnet addresses are populated in all six V4 address dictionaries (router, quoter, stateview, permit2, poolmanager, position_manager), but _position_descriptor_contract_addresses_v4 stores empty strings "" for both new networks — _str_to_addr("") raises NameNotFound, which is silently swallowed, leaving self.position_descriptor unset.
• Silent partial init: the new try/except pattern logs failures but does not set the attribute to None; every downstream method that uses the unset attribute (currencyRatioPriority, tokenURI, approve, etc.) will raise AttributeError with no helpful context.
• Casing inconsistency: several new sepolia entries use mixed-case EIP-55 checksummed strings while all existing entries are lowercase.

Confidence Score: 3/5

Not ready to merge — the empty-string position descriptor addresses on testnet will silently leave the instance partially initialised, and the broader swallow-and-continue pattern exposes every method that touches those contracts to opaque AttributeErrors at runtime.

The constructor refactor is well-intentioned but leaves the object in an undefined state when a contract address is missing or empty; callers get no indication of this during construction and see confusing AttributeErrors later. This is directly triggered by the empty-string entries added in the same PR for position_descriptor on Sepolia and Unichain Sepolia.

Both files need attention: uniswap/constants.py for the empty position_descriptor addresses and mixed-case hex strings, and uniswap/uniswap4.py for the silent partial-initialisation pattern in the constructor.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Caller
    participant Uniswap4.__init__
    participant constants.py
    participant _str_to_addr
    participant _load_contract

    Caller->>Uniswap4.__init__: new Uniswap4(address, key, ...)
    Uniswap4.__init__->>constants.py: lookup address maps by net_name
    constants.py-->>Uniswap4.__init__: returns address strings (may be "")

    loop for each contract
        Uniswap4.__init__->>_str_to_addr: _str_to_addr(address_string)
        alt address valid
            _str_to_addr-->>Uniswap4.__init__: Address bytes
            Uniswap4.__init__->>_load_contract: load ABI + attach to Web3
            _load_contract-->>Uniswap4.__init__: Contract object
            Uniswap4.__init__->>Uniswap4.__init__: "self.X = contract"
        else address is empty or invalid
            _str_to_addr-->>Uniswap4.__init__: raises NameNotFound
            Uniswap4.__init__->>Uniswap4.__init__: logger.error — self.X never set
        end
    end

    Uniswap4.__init__-->>Caller: returns without error
    Caller->>Uniswap4.__init__: self.position_descriptor.functions.tokenURI(...)
    Uniswap4.__init__-->>Caller: AttributeError: no attribute 'position_descriptor'

_{Reviews (1): Last reviewed commit: "Add testnets, minor constructor improvem..." | Re-trigger Greptile}