{{ message }}
Enable caching to reduce RPC calls#276
Merged
Merged
Conversation
enable caching, will reduce RPC calls for method chainID
Member
Contributor
Author
|
good call @ErikBjare , adding changes |
- custom eth caching middleware creation - custom SIMPLE_CACHE_RPC_WHITELIST - flag to enable/disable caching for class Uniswap
Contributor
Author
|
added changes, looking for any commentary |
ErikBjare
reviewed
Oct 12, 2022
ErikBjare
left a comment
ErikBjare
left a comment
Member
There was a problem hiding this comment.
Looks good! Going to let CI run now and will merge if it works :)
ErikBjare
reviewed
Oct 12, 2022
Codecov ReportBase: 84.56% // Head: 84.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 84.56% 84.13% -0.43%
==========================================
Files 10 10
Lines 1030 1040 +10
==========================================
+ Hits 871 875 +4
- Misses 159 165 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable caching, will reduce RPC calls for method chainID