You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BTW, I'm using uniswap-python on arbitrum, and I had to monkey patch _get_tx_params and remove the "gas" parameter, otherwise I was receiving "insufficient funds for gas". Perhaps it's something specific to my setup, but I thought that it might be useful for others if they also face such problem.
I've checked some uni swaps on arbitrum and it turns out txn requires gas spendings ~1m but _get_tx_param has hardcoded 250k limit. So I'm quite sure it isn't about your setup.
BTW, I'm using uniswap-python on arbitrum, and I had to monkey patch _get_tx_params and remove the "gas" parameter, otherwise I was receiving "insufficient funds for gas".
Perhaps the gas parameter could be removed entirely from _get_tx_params? Perhaps we should use estimate_gas instead?
I wasn't sure that it's not something specific to my case. I'm curious why it's different from L1 gas usage.
Merging this for now, we'll deal with any issues in future PRs.
ErikBjare
changed the title
Update constants.py; added Optimism and Arbitrum support
feat: added Optimism and Arbitrum support (updated constants.py)
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185
Closes #183
Closes #176