{{ message }}
Repository navigation
Move width over to relativetime marker attributes - #8572
Open
Manishearth wants to merge 3 commits into
Open
Manishearth wants to merge 3 commits into
Manishearth wants to merge 3 commits into
Conversation
Manishearth
requested review from
a team,
pdogr,
robertbastian and
sffc
as code owners
October 8, 2026 00:38
Member
Author
Manishearth
force-pushed
the
relativetime-marker-attributes
branch
from
October 8, 2026 21:18
626f859 to
5c77bec
Compare
robertbastian
left a comment
robertbastian
left a comment
Member
There was a problem hiding this comment.
If there's significant deduplication, we should use marker attributes. This is also the reason we're using attributes for width in list formatter. It looks like this is the case here:
datetime/relative/day/v1, af/L, 197B, 105B, 2a58f0784bcc7728
datetime/relative/day/v1, af/N, -> af/L
datetime/relative/day/v1, af/S, -> af/L
| icu_provider::data_marker!( | ||
| /// `DatetimeRelativeSecondLongV1` | ||
| DatetimeRelativeSecondLongV1, | ||
| /// `DatetimeRelativeSecondV1` |
Member
There was a problem hiding this comment.
issue: document the marker attributes architecture on each marker
Member
|
we should deal with widths how DisplayNames deals with widths. Short -> Medium, Long -> Medium, and Medium has everything, and Short and Long are both sparse. |
Member
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #802
I'm not sure of this, @sffc @robertbastian thoughts?
I think units being markers makes a lot of sense. Widths could be markers but I'm not convinced they need to be. Apparently there's a lot of overlap between widths, which means that having them be attributes reduces overall data size.
Changelog: N/A
We should make one big relativetime changelog entry