{{ message }}
Repository navigation
docs(cli): clarify that --output json requires extraction strategy - #2335
Merged
Merged
Conversation
Collaborator
ege-arhan
force-pushed
the
fix/cli-json-output-help
branch
from
October 12, 2026 11:08
5184ba2 to
2229adc
Compare
Contributor
Author
This was referenced Oct 12, 2026
ntohidi
approved these changes
Oct 12, 2026
ntohidi
left a comment
ntohidi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @ege-arhan! The help text matches the early error we merged in #2362 ("-o json needs an extraction strategy (-j or -e)"), so --help and the error now say the same thing. I checked that crwl crawl --help renders it, and that it merges cleanly with current develop.
Approving. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2334
Clarifies in click option help that
-o jsonexpects an extraction strategy or schema to be set for structured extractions, preventing user confusion when raw markdown/HTML is returned.