{{ message }}
Fix docker-ops branch placeholder handling#48
Open
fqjony wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the docker-ops reusable workflow’s Docker build-arg placeholder parsing (notably for branch names containing / and &) and updates workflow dependencies by bumping actions/checkout to v7. It also adds a small Bash regression test to prevent regressions in placeholder replacement behavior.
Changes:
- Replace
sed-based placeholder substitution with Bash parameter expansion and disablepatsub_replacementto handle&safely. - Replace
echo -emulti-line output writes withprintfto emitGITHUB_OUTPUTvalues more reliably. - Add a focused regression test for
{{branch}}/{{version}}placeholder handling and bumpactions/checkoutfromv6→v7across workflows.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fqjony
added
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
.github/workflows/docker-ops.yml:678
- Quote
$GITHUB_OUTPUTconsistently when redirecting. While the path is usually space-free on GitHub-hosted runners, quoting prevents edge-case failures and matches the quoting used for the multiline write just above.
else
# No build args provided
echo "build_args=" >> $GITHUB_OUTPUT
echo "ℹ️ No build arguments provided"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-opsbuild-arg placeholder replacement for branch names containing/or&.echo -eoutput handling withprintffor multilineGITHUB_OUTPUTwrites.actions/checkout@v7upgrade across workflows.Scope
Related PRs
Validation
dev.kit repopython3 /Users/jonyfq/.codex/scripts/repo_context_audit.py /Users/jonyfq/git/udx/reusable-workflowsbash tests/docker-ops-build-args.sh.github/workflows/*.ymlfiles with RubyPsych.bash -n ci/review-dependabot-actions.shbash -n ci/copilot-dependabot-risk-hints.shsafeand would comment/merge without writing.actions/checkout@v6, unsafesedplaceholder replacement, orecho -e "$BUILD_ARGS"pattern in workflow/test files.