fix: pass IsBase64 options correctly by aseyfpour · Pull Request #2549 · typestack/class-validator · GitHub
Skip to content

fix: pass IsBase64 options correctly#2549

Merged
braaar merged 4 commits into
typestack:developfrom
aseyfpour:fix-base64
Jan 17, 2025
Merged

fix: pass IsBase64 options correctly#2549
braaar merged 4 commits into
typestack:developfrom
aseyfpour:fix-base64

Conversation

@aseyfpour

@aseyfpour aseyfpour commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Description

In the IsBase64 decorator, constraints weren’t passed to isBase64. This issue has been fixed in this PR.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #2548
closes #2383

aseyfpour and others added 3 commits November 1, 2024 15:26
@aseyfpour

Copy link
Copy Markdown
Contributor Author

@braaar braaar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to a cleaner test implementation than #2383, I would like to merge this.

Thank you, and sorry for the wait

@braaar braaar changed the title fix: fill base64 options correctly fix: fill IsBase64 options correctly Jan 17, 2025
@braaar braaar changed the title fix: fill IsBase64 options correctly fix: pass IsBase64 options correctly Jan 17, 2025
@braaar braaar merged commit 0c87beb into typestack:develop Jan 17, 2025
@github-actions

Copy link
Copy Markdown

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

fix: base64 options doesn't apply

2 participants